Skip to content

fix(compiler-cli): mark private method as error in template file (#16451)#19740

Closed
mkoczka wants to merge 0 commit into
angular:masterfrom
mkoczka:private-methods-error
Closed

fix(compiler-cli): mark private method as error in template file (#16451)#19740
mkoczka wants to merge 0 commit into
angular:masterfrom
mkoczka:private-methods-error

Conversation

@mkoczka

@mkoczka mkoczka commented Oct 16, 2017

Copy link
Copy Markdown

Reference to a private method in the template will now report an error.

PR Close #16451

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #16451

What is the new behavior?

Reference to private methods in the template will now raise an error.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@googlebot

googlebot commented Oct 16, 2017

Copy link
Copy Markdown

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@mkoczka mkoczka mentioned this pull request Oct 16, 2017
Closed
@mkoczka mkoczka closed this Oct 16, 2017
@mkoczka mkoczka force-pushed the private-methods-error branch from db9593c to 405ccc7 Compare October 16, 2017 12:17
@mkoczka mkoczka deleted the private-methods-error branch October 16, 2017 12:17
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 12, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: no

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Language Service is not marking private methods as errors in template files

2 participants

@mkoczka @googlebot