perf(core): avoid pulling in jit-specific code in aot bundles#37372
Closed
crisbeto wants to merge 1 commit into
Closed
perf(core): avoid pulling in jit-specific code in aot bundles#37372crisbeto wants to merge 1 commit into
crisbeto wants to merge 1 commit into
Conversation
crisbeto
force-pushed
the
FW-2193/compiler-facade-aot
branch
3 times, most recently
from
4974c11 to
e0c1ae7
Compare
crisbeto
added
area: core
devversion
reviewed
Jun 1, 2020
crisbeto
force-pushed
the
FW-2193/compiler-facade-aot
branch
3 times, most recently
from
dd27312 to
1039cae
Compare
devversion
approved these changes
Jun 4, 2020
IgorMinar
approved these changes
Jun 4, 2020
IgorMinar
left a comment
IgorMinar
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Thank you!
Reviewed-for: global-approvers
mhevery
approved these changes
Jun 5, 2020
crisbeto
force-pushed
the
FW-2193/compiler-facade-aot
branch
from
1039cae to
165e02d
Compare
In angular#29083 a call to `getCompilerFacade` was added to `ApplicationRef` which pulls in a bit of JIT-specific code. Since the code path that calls the function can't be hit for an AOT-compiled app, these changes add an `ngJitMode` guard which will allow for dead code elimination to drop it completely. Testing it out against a new CLI project showed a difference of ~1.2kb.
crisbeto
force-pushed
the
FW-2193/compiler-facade-aot
branch
from
165e02d to
c5c5ee3
Compare
IgorMinar
added
action: merge
atscott
added
target: major
Contributor
|
@crisbeto As discussed, switching this to master only as there are conflicts with the patch branch. Please create a follow-up for patch only |
crisbeto
added a commit
to crisbeto/angular
that referenced
this pull request
Jun 9, 2020
…r#37372) In angular#29083 a call to `getCompilerFacade` was added to `ApplicationRef` which pulls in a bit of JIT-specific code. Since the code path that calls the function can't be hit for an AOT-compiled app, these changes add an `ngJitMode` guard which will allow for dead code elimination to drop it completely. Testing it out against a new CLI project showed a difference of ~1.2kb. PR Close angular#37372
atscott
pushed a commit
that referenced
this pull request
Jun 9, 2020
#37514) In #29083 a call to `getCompilerFacade` was added to `ApplicationRef` which pulls in a bit of JIT-specific code. Since the code path that calls the function can't be hit for an AOT-compiled app, these changes add an `ngJitMode` guard which will allow for dead code elimination to drop it completely. Testing it out against a new CLI project showed a difference of ~1.2kb. PR Close #37372 PR Close #37514
ngwattcos
pushed a commit
to ngwattcos/angular
that referenced
this pull request
Jun 25, 2020
…r#37372) In angular#29083 a call to `getCompilerFacade` was added to `ApplicationRef` which pulls in a bit of JIT-specific code. Since the code path that calls the function can't be hit for an AOT-compiled app, these changes add an `ngJitMode` guard which will allow for dead code elimination to drop it completely. Testing it out against a new CLI project showed a difference of ~1.2kb. PR Close angular#37372
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
profanis
pushed a commit
to profanis/angular
that referenced
this pull request
Sep 5, 2020
…r#37372) In angular#29083 a call to `getCompilerFacade` was added to `ApplicationRef` which pulls in a bit of JIT-specific code. Since the code path that calls the function can't be hit for an AOT-compiled app, these changes add an `ngJitMode` guard which will allow for dead code elimination to drop it completely. Testing it out against a new CLI project showed a difference of ~1.2kb. PR Close angular#37372
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #29083 a call to
getCompilerFacadewas added toApplicationRefwhich pulls in a bit of JIT-specific code. Since the code path that calls the function can't be hit for an AOT-compiled app, these changes add anngJitModeguard which will allow for dead code elimination to drop it completely. Testing it out against a new CLI project showed a difference of ~1.2kb.