Skip to content

docs: remove redundant web-worker nav#37289

Closed
ajitsinghkaler wants to merge 1 commit into
angular:masterfrom
ajitsinghkaler:redundant-navigation
Closed

docs: remove redundant web-worker nav#37289
ajitsinghkaler wants to merge 1 commit into
angular:masterfrom
ajitsinghkaler:redundant-navigation

Conversation

@ajitsinghkaler

@ajitsinghkaler ajitsinghkaler commented May 26, 2020

Copy link
Copy Markdown
Contributor

Web- worker was 2 times in the nav pointing towards the same file, just with different names removed one to remove redundancy

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Redundant web worker nav

Issue Number: N/A

What is the new behavior?

No redundant web worker nav

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove Bot requested a review from IgorMinar May 26, 2020 04:30
@ajitsinghkaler

ajitsinghkaler commented May 26, 2020

Copy link
Copy Markdown
Contributor Author

@IgorMinar can you please tell me why saucelabs is failing

@IgorMinar

IgorMinar commented May 26, 2020

Copy link
Copy Markdown
Contributor

@ajitsinghkaler the failure looks like a flake / dev infrastructure issue.

But more importantly are you sure that this is a duplicate? I don't see this item being in the menu twice. Am I missing something?

@ajitsinghkaler

ajitsinghkaler commented May 26, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@IgorMinar "title": "Web Workers in Angular", and "title": "Web Workers" are the same under techniques nav

@ajitsinghkaler
docs: remove redundant web-worker nav
ecddde1 
Web- worker was 2 times in the nav pointing towards the same file, just with different names removed one to remove redundancy
@ajitsinghkaler ajitsinghkaler force-pushed the redundant-navigation branch from 41c0df4 to ecddde1 Compare May 27, 2020 02:06
@ngbot ngbot Bot added this to the needsTriage milestone Jun 3, 2020
@ajitsinghkaler

ajitsinghkaler commented Jun 6, 2020

Copy link
Copy Markdown
Contributor Author

@IgorMinar can you please review this again

@mary-poppins

mary-poppins commented Jun 10, 2020

Copy link
Copy Markdown

You can preview 41c0df4 at https://pr37289-41c0df4.ngbuilds.io/.
You can preview ecddde1 at https://pr37289-ecddde1.ngbuilds.io/.

IgorMinar
IgorMinar approved these changes Jun 10, 2020
View reviewed changes

@IgorMinar IgorMinar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OMG. I see it now. Thanks for pointing it out @ajitsinghkaler !

@IgorMinar IgorMinar added target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker labels Jun 10, 2020
@atscott atscott closed this in a398d6a Jun 10, 2020
atscott pushed a commit that referenced this pull request Jun 10, 2020
@ajitsinghkaler @atscott
docs: remove redundant web-worker nav (#37289)
83853a2 
Web- worker was 2 times in the nav pointing towards the same file, just with different names removed one to remove redundancy

PR Close #37289
@ajitsinghkaler ajitsinghkaler deleted the redundant-navigation branch June 14, 2020 03:35
ngwattcos pushed a commit to ngwattcos/angular that referenced this pull request Jun 25, 2020
@ajitsinghkaler @ngwattcos
docs: remove redundant web-worker nav (angular#37289)
c609ee8 
Web- worker was 2 times in the nav pointing towards the same file, just with different names removed one to remove redundancy

PR Close angular#37289
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Jul 15, 2020

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Jul 15, 2020
profanis pushed a commit to profanis/angular that referenced this pull request Sep 5, 2020
@ajitsinghkaler @profanis
docs: remove redundant web-worker nav (angular#37289)
731877f 
Web- worker was 2 times in the nav pointing towards the same file, just with different names removed one to remove redundancy

PR Close angular#37289
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@IgorMinar IgorMinar IgorMinar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

needsTriage

Development

Successfully merging this pull request may close these issues.

5 participants

@ajitsinghkaler @IgorMinar @mary-poppins @matsko @googlebot