Skip to content

docs: wrong links in lifecylcle hooks api documentation#36557

Closed
ajitsinghkaler wants to merge 2 commits into
angular:masterfrom
ajitsinghkaler:lifecycle-links
Closed

docs: wrong links in lifecylcle hooks api documentation#36557
ajitsinghkaler wants to merge 2 commits into
angular:masterfrom
ajitsinghkaler:lifecycle-links

Conversation

@ajitsinghkaler

@ajitsinghkaler ajitsinghkaler commented Apr 10, 2020

Copy link
Copy Markdown
Contributor

lifecylcle hooks api detailed documenation contained all links were pointing to onChanges documentaion made them point there own hooks

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Lifecyle points to wrong links

Issue Number: N/A

What is the new behavior?

Lifecycles pointing to right links

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove Bot requested a review from kara April 10, 2020 11:35
@ajitsinghkaler ajitsinghkaler changed the title docs: wrong links in lifecylcle hooks api documentaion docs: wrong links in lifecylcle hooks api documentation Apr 10, 2020
@ajitsinghkaler ajitsinghkaler force-pushed the lifecycle-links branch 2 times, most recently from d64f4b7 to a748914 Compare April 11, 2020 06:40
@ngbot ngbot Bot added this to the needsTriage milestone Apr 13, 2020
@ajitsinghkaler

ajitsinghkaler commented Apr 17, 2020

Copy link
Copy Markdown
Contributor Author

@kapunahelewong this is mostly related to documentation can you please have a look

@ngbot ngbot Bot modified the milestones: needsTriage, Backlog Apr 20, 2020
@ajitsinghkaler

ajitsinghkaler commented Jun 6, 2020

Copy link
Copy Markdown
Contributor Author

@kapunahelewong @kara @jbogarthyde can you please review this

jbogarthyde
jbogarthyde reviewed Jun 8, 2020
View reviewed changes

@jbogarthyde jbogarthyde left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!
The Lifecycle Hooks guide has been recently rewritten, and its title is now "Hooking into the component lifecycle". "Lifecycle hooks guide" is adequately descriptive, but to be perfectly clear that it is descriptive, it should be sentence-style and inside the link: Lifecycle hooks guide.

@ajitsinghkaler
docs: wrong links in lifecycle hooks api documentaion
391c7f4 
lifecycle hooks api detailed documentation contained links which were pointing to onChanges hook only which is removed, made each hook point towards its deafult page link
@ajitsinghkaler
fixup! docs: wrong links in lifecycle hooks api documentaion
39b48ec
@ajitsinghkaler

ajitsinghkaler commented Jun 9, 2020

Copy link
Copy Markdown
Contributor Author

@jbogarthyde made the changes

jbogarthyde
jbogarthyde approved these changes Jun 9, 2020
View reviewed changes

@jbogarthyde jbogarthyde left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kapunahelewong
kapunahelewong approved these changes Jun 9, 2020
View reviewed changes

@kapunahelewong kapunahelewong left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @ajitsinghkaler!

Reviewed-for: global-docs-approvers

@kapunahelewong kapunahelewong added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jun 9, 2020
@kapunahelewong kapunahelewong removed the request for review from kara June 9, 2020 17:10
atscott pushed a commit that referenced this pull request Jun 9, 2020
@ajitsinghkaler @atscott
docs: wrong links in lifecycle hooks api documentaion (#36557)
ec6a7ab 
lifecycle hooks api detailed documentation contained links which were pointing to onChanges hook only which is removed, made each hook point towards its deafult page link

PR Close #36557
@atscott atscott closed this in cb13731 Jun 9, 2020
@ajitsinghkaler ajitsinghkaler deleted the lifecycle-links branch June 14, 2020 13:45
ngwattcos pushed a commit to ngwattcos/angular that referenced this pull request Jun 25, 2020
@ajitsinghkaler @ngwattcos
docs: wrong links in lifecycle hooks api documentaion (angular#36557)
30eb45a 
lifecycle hooks api detailed documentation contained links which were pointing to onChanges hook only which is removed, made each hook point towards its deafult page link

PR Close angular#36557
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Jul 15, 2020

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Jul 15, 2020
profanis pushed a commit to profanis/angular that referenced this pull request Sep 5, 2020
@ajitsinghkaler @profanis
docs: wrong links in lifecycle hooks api documentaion (angular#36557)
c2f8a82 
lifecycle hooks api detailed documentation contained links which were pointing to onChanges hook only which is removed, made each hook point towards its deafult page link

PR Close angular#36557
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@kapunahelewong kapunahelewong kapunahelewong approved these changes

@jbogarthyde jbogarthyde jbogarthyde approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes effort1: hours risk: low target: patch This PR is targeted for the next patch release type: bug/fix

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

5 participants

@ajitsinghkaler @kapunahelewong @jbogarthyde @atscott @googlebot