Skip to content

docs: remove out of date GDEs#36467

Closed
StephenFluin wants to merge 1 commit into
angular:masterfrom
StephenFluin:stephen/remove-gdes
Closed

docs: remove out of date GDEs#36467
StephenFluin wants to merge 1 commit into
angular:masterfrom
StephenFluin:stephen/remove-gdes

Conversation

@StephenFluin

@StephenFluin StephenFluin commented Apr 6, 2020

Copy link
Copy Markdown
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Documentation content changes

@pullapprove pullapprove Bot requested a review from IgorMinar April 6, 2020 23:11
@gabrielbussolo

gabrielbussolo commented Apr 6, 2020

Copy link
Copy Markdown

Hey @StephenFluin , aren't this guys GDE anymore?

gabrielbussolo
gabrielbussolo suggested changes Apr 7, 2020
View reviewed changes

@gabrielbussolo gabrielbussolo left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @StephenFluin, I searched for this guys at "Directory of Experts". And I found this guy Filip Bruun Bech-Larsen, can u verify and submit again?
Thanks :)

Comment thread aio/content/marketing/contributors.json Outdated

@gabrielbussolo gabrielbussolo Apr 7, 2020

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I searched for this guy at https://developers.google.com/community/experts/directory and I found him.

@StephenFluin StephenFluin Apr 7, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

He's still a Web Technologies GDE, just not an Angular one.

@gabrielbussolo gabrielbussolo Apr 7, 2020 •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry, I hadn't noticed the difference. Thanks!

gabrielbussolo
gabrielbussolo approved these changes Apr 7, 2020
View reviewed changes

@gabrielbussolo gabrielbussolo left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the people that were removed.
Looks good for me 👍

gkalpak
gkalpak suggested changes Apr 7, 2020
View reviewed changes

@gkalpak gkalpak left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the corresponding images from [aio/content/images/bios/], if they are no longer needed 🙏

@StephenFluin StephenFluin force-pushed the stephen/remove-gdes branch from 9056e48 to f2cf629 Compare April 7, 2020 15:33
@ngbot ngbot Bot added this to the needsTriage milestone Apr 9, 2020
@IgorMinar IgorMinar added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jun 10, 2020
@atscott atscott force-pushed the stephen/remove-gdes branch from f2cf629 to 3d32157 Compare June 10, 2020 18:54
@atscott

atscott commented Jun 10, 2020

Copy link
Copy Markdown
Contributor

Hi @StephenFluin, could you amend the commit message to conform to the length requirements in the body? Thanks!

@StephenFluin @mhevery
docs: remove out of date GDEs
6a1b756 
Periodic documentation cleanup of GDEs which are no longer in the Angular program.

Removed:
 - "Filip Bruun Bech-Larsen"
 - "Vinci Rufus"
 - "Jeff Cross"
@mhevery mhevery force-pushed the stephen/remove-gdes branch from 3d32157 to 6a1b756 Compare June 11, 2020 18:02
mhevery pushed a commit that referenced this pull request Jun 11, 2020
@StephenFluin @mhevery
docs: remove out of date GDEs (#36467)
9d2d0ca 
Periodic documentation cleanup of GDEs which are no longer in the Angular program.

Removed:
 - "Filip Bruun Bech-Larsen"
 - "Vinci Rufus"
 - "Jeff Cross"

PR Close #36467
@mhevery mhevery closed this in 39f9734 Jun 11, 2020
ngwattcos pushed a commit to ngwattcos/angular that referenced this pull request Jun 25, 2020
@StephenFluin @ngwattcos
docs: remove out of date GDEs (angular#36467)
3ecffe9 
Periodic documentation cleanup of GDEs which are no longer in the Angular program.

Removed:
 - "Filip Bruun Bech-Larsen"
 - "Vinci Rufus"
 - "Jeff Cross"

PR Close angular#36467
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Jul 12, 2020

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Jul 12, 2020
profanis pushed a commit to profanis/angular that referenced this pull request Sep 5, 2020
@StephenFluin @profanis
docs: remove out of date GDEs (angular#36467)
71bf9fe 
Periodic documentation cleanup of GDEs which are no longer in the Angular program.

Removed:
 - "Filip Bruun Bech-Larsen"
 - "Vinci Rufus"
 - "Jeff Cross"

PR Close angular#36467
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@IgorMinar IgorMinar IgorMinar approved these changes

@gabrielbussolo gabrielbussolo gabrielbussolo approved these changes

@gkalpak gkalpak gkalpak approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

needsTriage

Development

Successfully merging this pull request may close these issues.

6 participants

@StephenFluin @gabrielbussolo @atscott @IgorMinar @gkalpak @googlebot