Skip to content

build(docs-infra): do not include CI-specific config in docs examples ZIP archives #36018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gkalpak wants to merge 2 commits into from
Closed

build(docs-infra): do not include CI-specific config in docs examples ZIP archives #36018

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
15093f1
build(docs-infra): remove obsolete properties from `zipper.json` files
gkalpak Mar 16, 2020
fd45beb
build(docs-infra): do not include CI-specific config in docs examples…
gkalpak Mar 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions aio/content/examples/i18n/zipper.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,9 @@
{
"files":[
"files": [
"!dist/",
"!**/*.d.ts",
"!src/**/*.js",
"!doc-files/**/*",
"**/*.xlf"
],
"removeSystemJsConfig": true,
"type": "i18n"
]
}
6 changes: 2 additions & 4 deletions aio/content/examples/universal/zipper.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
{
"files":[
"files": [
"!dist/",
"!**/*.d.ts",
"!**/src/**/*.js"
],
"removeSystemJsConfig": false,
"type": "universal"
]
}
15 changes: 0 additions & 15 deletions aio/tools/example-zipper/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,21 +59,6 @@ The problem is that not all examples have a stackblitz but they could offer a zi
In those cases, you can create a `zipper.json` file with the same syntax. It will be ignored by the
stackblitz tool.

## Choosing the zip "type"

In both `stackblitz.json` and `zipper.json` you can use two extra properties for the zipper configuration:

```
{
...
"removeSystemJsConfig": true,
"type": "testing"
}
```

This would generate a zip for a testing application and it will also remove everything related with
SystemJS.

## Executing the zip generation

`generateZips.js` will create a zip for each `stackblitz.json` or `zipper.json` it finds.
Expand Down
2 changes: 1 addition & 1 deletion aio/tools/example-zipper/exampleZipper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ class ExampleZipper {
'!**/npm-debug.log',
'!**/example-config.json',
'!**/wallaby.js',
'!e2e/protractor-puppeteer.conf.js',
'!**/e2e/protractor-puppeteer.conf.js',
// AOT related files
'!**/aot/**/*.*',
'!**/*-aot.*'
Expand Down