Skip to content
This repository was archived by the owner on Sep 5, 2023. It is now read-only.

chore: prevent normalization of semver versioning#81

Merged
dandhlee merged 2 commits into
masterfrom
remove-semver-normalization
Apr 16, 2021
Merged

chore: prevent normalization of semver versioning#81
dandhlee merged 2 commits into
masterfrom
remove-semver-normalization

Conversation

@dandhlee

Copy link
Copy Markdown
Contributor

When there is a patch version added to semver versioning, setuptools.setup(version) will normalize the versioning from -patch to .patch which is not correct SEMVER versioning. The added feature with setuptools.sic(version) will prevent this from happening.

@dandhlee dandhlee requested a review from a team April 14, 2021 23:31
@product-auto-label product-auto-label Bot added the api: cloudbilling Issues related to the googleapis/python-billingbudgets API. label Apr 14, 2021
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 14, 2021
@dandhlee dandhlee merged commit cb48f0e into master Apr 16, 2021
@dandhlee dandhlee deleted the remove-semver-normalization branch April 16, 2021 21:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: cloudbilling Issues related to the googleapis/python-billingbudgets API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants