fix(ivy): platform module bootstrap does not resolve resources #29083
Closed
devversion wants to merge 2 commits into
Closed
fix(ivy): platform module bootstrap does not resolve resources #29083devversion wants to merge 2 commits into
devversion wants to merge 2 commits into
Conversation
devversion
commented
Mar 3, 2019
devversion
commented
Member
- See individual commits.
devversion
force-pushed
the
fix/ivy-component-resources-not-resolved-in-jit-mode
branch
5 times, most recently
from
a0e4954 to
b5dd77a
Compare
devversion
added
action: review
Currently with ViewEngine, if someone runs the platform's `bootstrapModule` method in order to boostrap a module in JIT mode, external component resources are properly resolved *automatically*. Currently with Ivy, the developer would need to manually call `resolveComponentResources` in order to asynchronously fetch the determined external component resources. In order to make this backwards compatible with ViewEngine, and also since platforms can already specify a `ResourceLoader` compiler provider, we need to automatically resolve all external component resources on module bootstrap. -- Since the `ResourceLoader` is part of the `@angular/compiler`, because ViewEngine performed the factory creation in the compiler, we can't access the `ResourceLoader` token from within core. In order to workaround this without introducing a breaking change, we just proxy the `ResourceLoader` token to `core` through the compiler facade. In the future, we should be able to move the `ResourceLoader` to core when ViewEngine code no longer exists in the `@angular/compiler`.
With 63fb6c08cf1d69f912a0a4e9a28846d6e6985d04, the bug that required us to temporarily disable these two SystemJS JIT tests has been fixed. Therefore we can re-enable these tests.
devversion
force-pushed
the
fix/ivy-component-resources-not-resolved-in-jit-mode
branch
from
b5dd77a to
e97655c
Compare
alxhub
reviewed
Mar 4, 2019
alxhub
approved these changes
Mar 12, 2019
devversion
added
action: merge
Contributor
kara
added
target: major
Contributor
|
@devversion Could you create a separate PR for patch? Not merging cleanly |
kara
pushed a commit
that referenced
this pull request
Mar 12, 2019
With 63fb6c08cf1d69f912a0a4e9a28846d6e6985d04, the bug that required us to temporarily disable these two SystemJS JIT tests has been fixed. Therefore we can re-enable these tests. PR Close #29083
wKoza
pushed a commit
to wKoza/angular
that referenced
this pull request
Apr 17, 2019
…ar#29083) Currently with ViewEngine, if someone runs the platform's `bootstrapModule` method in order to boostrap a module in JIT mode, external component resources are properly resolved *automatically*. Currently with Ivy, the developer would need to manually call `resolveComponentResources` in order to asynchronously fetch the determined external component resources. In order to make this backwards compatible with ViewEngine, and also since platforms can already specify a `ResourceLoader` compiler provider, we need to automatically resolve all external component resources on module bootstrap. -- Since the `ResourceLoader` is part of the `@angular/compiler`, because ViewEngine performed the factory creation in the compiler, we can't access the `ResourceLoader` token from within core. In order to workaround this without introducing a breaking change, we just proxy the `ResourceLoader` token to `core` through the compiler facade. In the future, we should be able to move the `ResourceLoader` to core when ViewEngine code no longer exists in the `@angular/compiler`. PR Close angular#29083
wKoza
pushed a commit
to wKoza/angular
that referenced
this pull request
Apr 17, 2019
With 63fb6c08cf1d69f912a0a4e9a28846d6e6985d04, the bug that required us to temporarily disable these two SystemJS JIT tests has been fixed. Therefore we can re-enable these tests. PR Close angular#29083
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.