ci: exclude unnedeed files and directories from angular-robot g3sync check#27653
Closed
IgorMinar wants to merge 2 commits into
Closed
ci: exclude unnedeed files and directories from angular-robot g3sync check#27653IgorMinar wants to merge 2 commits into
IgorMinar wants to merge 2 commits into
Conversation
…check We are overincluding files, all of these are not necessary in google3 and should not be synced because it's only slowing us down. Related CL: http://cl/225197013
IgorMinar
added
action: merge
ocombe
approved these changes
Dec 13, 2018
alexeagle
approved these changes
Dec 13, 2018
alexeagle
left a comment
alexeagle
left a comment
Contributor
There was a problem hiding this comment.
since you're touching it, we should take another stab at having the list appear only once. We'd need copybara to be able to include the same list of patterns that angular-robot does
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are overincluding files, all of these are not necessary in google3 and should not be synced
because it's only slowing us down.
Related CL: http://cl/225197013