Skip to content

rollback/router 26243#27516

Closed
IgorMinar wants to merge 2 commits into
angular:masterfrom
IgorMinar:rollback/router-26243
Closed

rollback/router 26243#27516
IgorMinar wants to merge 2 commits into
angular:masterfrom
IgorMinar:rollback/router-26243

Conversation

@IgorMinar

Copy link
Copy Markdown
Contributor

Breaks patheon. see cl/224256517

…d outlet (angular#26243)"

This reverts commit 20cef50.

Breaks Pantheon see cl/224256517.
@mary-poppins

Copy link
Copy Markdown

You can preview c2535b9 at https://pr27516-c2535b9.ngbuilds.io/.

@IgorMinar IgorMinar added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Dec 6, 2018
@ngbot

ngbot Bot commented Dec 6, 2018

Copy link
Copy Markdown

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "buildkite/angular" is failing
    pending missing required labels: PR target: *
    pending status "code-review/pullapprove" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

IgorMinar added a commit that referenced this pull request Dec 6, 2018
…d outlet (#26243)" (#27516)

This reverts commit 20cef50.

Breaks Pantheon see cl/224256517.

PR Close #27516
IgorMinar added a commit that referenced this pull request Dec 6, 2018
…26243)" (#27516)

This reverts commit ccc77ca.

Breaks Pantheon see cl/224256517.

PR Close #27516
@IgorMinar IgorMinar closed this in 4f61832 Dec 6, 2018
IgorMinar added a commit that referenced this pull request Dec 6, 2018
…26243)" (#27516)

This reverts commit ccc77ca.

Breaks Pantheon see cl/224256517.

PR Close #27516
@miginmrs

Copy link
Copy Markdown
Contributor

@IgorMinar, Sorry I didn't understand what does it mean "Breaks patheon. see cl/224256517".
Can you please explain it to me or give me a link to cl/224256517 so I can try to fix it properly.
Thanks in advance 👍

@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants