fix(router): fix some empty path related navigation bugs by miginmrs · Pull Request #26243 · angular/angular

miginmrs · 2018-10-04T08:16:29Z

fix some empty path related navigation bugs

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #26224 , #10726

What is the new behavior?

The next path of a pathless activated route is no longer added to the url and the commands passed to the createUrlTree are no longer added as children of an undefined outlet of this path but as children of the actual url.
The navigation to aux routes with empty-path parent route is now possible.

Does this PR introduce a breaking change?

[ ] Yes
[X] No

miginmrs · 2018-10-05T19:22:16Z

@jasonaden @adriensamson @IgorMinar, Please some review, I get this exception with TravisCI but not locally and I don't understand what my tiny changes in route component have to do with render3 directive injection in core component ?

Chrome 67.0.3396 (Windows 7 0.0.0) di directive injection flags should check only the current node with @Self even with false positive FAILED
	Expected function to throw an Error.

        const App = createComponent('app', function(rf: RenderFlags, ctx: any) {
          if (rf & RenderFlags.Create) {
            elementStart(0, 'div', ['dirB', '']);
            element(1, 'div', ['dirA', '', 'dirC', '']);
            elementEnd();
          }
        }, 2, 0, [DirA, DirB, DirC]);

        expect(() => {
          (DirA as any)['__NG_ELEMENT_ID__'] = 1;
          (DirC as any)['__NG_ELEMENT_ID__'] = 257;
          new ComponentFixture(App);
        }).toThrowError(/Injector: NOT_FOUND \[DirB\]/);

Thank you very much for your attention

jasonaden · 2018-11-20T23:45:32Z

Presubmit

stop adding next path of pathless activated route to the url PR Close angular#26224

PR Close angular#10726

jasonaden · 2018-12-05T17:53:56Z

This looks good. I rebased and pushed back, so you'll see a force push on this branch. Will try to get this merged quickly.

jasonaden · 2018-12-05T17:56:29Z

Updated Presubmit

stop adding next path of pathless activated route to the url PR Close #26224 PR Close #26243

…#26243) PR Close #10726 PR Close #26243

…d outlet (angular#26243)" This reverts commit 20cef50. Breaks Pantheon see cl/224256517.

…ngular#26243)" This reverts commit ccc77ca. Breaks Pantheon see cl/224256517.

…d outlet (#26243)" (#27516) This reverts commit 20cef50. Breaks Pantheon see cl/224256517. PR Close #27516

…26243)" (#27516) This reverts commit ccc77ca. Breaks Pantheon see cl/224256517. PR Close #27516

…d outlet (#26243)" (#27516) This reverts commit 20cef50. Breaks Pantheon see cl/224256517. PR Close #27516

…26243)" (#27516) This reverts commit ccc77ca. Breaks Pantheon see cl/224256517. PR Close #27516

angular-automatic-lock-bot · 2019-09-14T09:52:33Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: yes label Oct 4, 2018

IgorMinar requested review from jasonaden and mhevery and removed request for jasonaden and mhevery October 4, 2018 22:43

miginmrs changed the title ~~fix(router): change processing url tree children condition~~ fix(router): fix some empty path related navigation bugs Oct 5, 2018

kara added the area: router label Oct 11, 2018

jasonaden self-requested a review November 20, 2018 23:41

jasonaden self-assigned this Nov 20, 2018

TGC79 mentioned this pull request Nov 23, 2018

bug(router) aux-routes not working with empty-path top-level routes #10726

Closed

jasonaden approved these changes Dec 5, 2018

View reviewed changes

miginmrs added 2 commits December 5, 2018 09:50

fix(router): change processing url tree children condition

0817bb2

stop adding next path of pathless activated route to the url PR Close angular#26224

fix(router): process empty path segment when preceding a named outlet

2b455d3

PR Close angular#10726

jasonaden force-pushed the my-fix-branch branch from 96aaf56 to 2b455d3 Compare December 5, 2018 17:53

jasonaden added the action: merge The PR is ready for merge by the caretaker label Dec 5, 2018

ngbot Bot added this to the needsTriage milestone Dec 5, 2018

jasonaden added the target: patch This PR is targeted for the next patch release label Dec 5, 2018

IgorMinar pushed a commit that referenced this pull request Dec 5, 2018

fix(router): change processing url tree children condition (#26243)

8167bfc

stop adding next path of pathless activated route to the url PR Close #26224 PR Close #26243

IgorMinar pushed a commit that referenced this pull request Dec 5, 2018

fix(router): process empty path segment when preceding a named outlet (…

2bc85fb

…#26243) PR Close #10726 PR Close #26243

IgorMinar closed this in ccc77ca Dec 5, 2018

IgorMinar pushed a commit that referenced this pull request Dec 5, 2018

fix(router): process empty path segment when preceding a named outlet (…

20cef50

…#26243) PR Close #10726 PR Close #26243

jasonaden added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Dec 5, 2018

IgorMinar added a commit to IgorMinar/angular that referenced this pull request Dec 6, 2018

Revert "fix(router): process empty path segment when preceding a name…

511880e

…d outlet (angular#26243)" This reverts commit 20cef50. Breaks Pantheon see cl/224256517.

IgorMinar added a commit to IgorMinar/angular that referenced this pull request Dec 6, 2018

Revert "fix(router): change processing url tree children condition (a…

c2535b9

…ngular#26243)" This reverts commit ccc77ca. Breaks Pantheon see cl/224256517.

IgorMinar added a commit that referenced this pull request Dec 6, 2018

Revert "fix(router): process empty path segment when preceding a name…

7bed896

…d outlet (#26243)" (#27516) This reverts commit 20cef50. Breaks Pantheon see cl/224256517. PR Close #27516

IgorMinar added a commit that referenced this pull request Dec 6, 2018

Revert "fix(router): change processing url tree children condition (#…

610472b

…26243)" (#27516) This reverts commit ccc77ca. Breaks Pantheon see cl/224256517. PR Close #27516

IgorMinar added a commit that referenced this pull request Dec 6, 2018

Revert "fix(router): process empty path segment when preceding a name…

4f61832

…d outlet (#26243)" (#27516) This reverts commit 20cef50. Breaks Pantheon see cl/224256517. PR Close #27516

IgorMinar added a commit that referenced this pull request Dec 6, 2018

Revert "fix(router): change processing url tree children condition (#…

091a504

…26243)" (#27516) This reverts commit ccc77ca. Breaks Pantheon see cl/224256517. PR Close #27516

angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 14, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(router): fix some empty path related navigation bugs#26243

fix(router): fix some empty path related navigation bugs#26243
miginmrs wants to merge 2 commits into
angular:masterfrom
miginmrs:my-fix-branch

miginmrs commented Oct 4, 2018 •

edited

Loading

Uh oh!

miginmrs commented Oct 5, 2018 •

edited

Loading

Uh oh!

jasonaden commented Nov 20, 2018

Uh oh!

jasonaden commented Dec 5, 2018

Uh oh!

jasonaden commented Dec 5, 2018

Uh oh!

angular-automatic-lock-bot Bot commented Sep 14, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

miginmrs commented Oct 4, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Uh oh!

miginmrs commented Oct 5, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jasonaden commented Nov 20, 2018

Uh oh!

jasonaden commented Dec 5, 2018

Uh oh!

jasonaden commented Dec 5, 2018

Uh oh!

angular-automatic-lock-bot Bot commented Sep 14, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

miginmrs commented Oct 4, 2018 •

edited

Loading

miginmrs commented Oct 5, 2018 •

edited

Loading