Skip to content

fix(aio): copy code button overlap fix on mobile#17302

Merged
IgorMinar merged 1 commit into
angular:masterfrom
sjtrimble:code-copy-button-mobile
Jun 8, 2017
Merged

fix(aio): copy code button overlap fix on mobile#17302
IgorMinar merged 1 commit into
angular:masterfrom
sjtrimble:code-copy-button-mobile

Conversation

@sjtrimble

@sjtrimble sjtrimble commented Jun 7, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x")

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
Closes #17247

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

@sjtrimble sjtrimble requested a review from wardbell June 7, 2017 17:12
@mary-poppins

mary-poppins commented Jun 7, 2017

Copy link
Copy Markdown

The angular.io preview for 4a83e1154e54a42bdeca739d18b2d41cc0c15a8f is available here.

@gkalpak

gkalpak commented Jun 7, 2017

Copy link
Copy Markdown
Member

This sure doesn't close #17248 😃

gkalpak
gkalpak reviewed Jun 7, 2017
View reviewed changes

@gkalpak gkalpak left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works better than before, but there can still be overlap:

copy-btn

(Example from the Hero object section of the tutorial.)

@sjtrimble

sjtrimble commented Jun 7, 2017

Copy link
Copy Markdown
Contributor Author

@gkalpak I tried to focus on mobile 480px or smaller but I will see if I can bump that up to cover this as well.

@wardbell

wardbell commented Jun 7, 2017

Copy link
Copy Markdown
Contributor

I thought we said our lower bound was 600px wide?

@sjtrimble sjtrimble force-pushed the code-copy-button-mobile branch from 4a83e11 to 6f3ac69 Compare June 7, 2017 18:11
@mary-poppins

mary-poppins commented Jun 7, 2017

Copy link
Copy Markdown

The angular.io preview for 6f3ac69 is available here.

@sjtrimble

sjtrimble commented Jun 7, 2017

Copy link
Copy Markdown
Contributor Author

@wardbell Take a look .. I checked a few scenarios and it looked better now across all sizes. I think someone changed some styles on the aio-code-pre blocks a while back which caused this to happen.

@IgorMinar IgorMinar merged commit 391ed63 into angular:master Jun 8, 2017
asnowwolf pushed a commit to asnowwolf/angular that referenced this pull request Aug 11, 2017
@sjtrimble
fix(aio): copy code button overlap fix on mobile (angular#17302)
295ec99
juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 28, 2017
@sjtrimble @juleskremer
fix(aio): copy code button overlap fix on mobile (angular#17302)
cf2d54a
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 11, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@wardbell wardbell Awaiting requested review from wardbell
2 more reviewers
@gkalpak gkalpak gkalpak left review comments
@IgorMinar IgorMinar IgorMinar approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

aio: code copy button overlays code

7 participants

@sjtrimble @mary-poppins @gkalpak @wardbell @IgorMinar @petebacondarwin @googlebot