build: fix and document the symlinks scripts for Windows#10213
build: fix and document the symlinks scripts for Windows#10213marclaval wants to merge 1 commit into
Conversation
|
@Mlaval it's not clear to me what this fixes and if the PR is a WIP or ready to go ? |
|
@vicb I know that when I made a PR, the create / remove symlinks did not work due to the @Mlaval What terminal are you using ? |
|
I'm using a recent version of Git Bash (2.6.2) and this PR fixes the issue you described with the '\r'. @vicb: there are more things to fix on the platform, but this one allows to at least run tests in a browser. |
Is it ok to merge still ? |
eed5622 to
2d7f7a8
Compare
|
I've updated the PR with the findings of @fknop so that the scripts also work in older bash. The commit message is now more explicit. It should be ok to merge. |
|
When it's been :) |
|
Green... Stupid phone! |
|
It is now, the e2e job went flaky. |
|
Lgtm. Can not merge from the mobile UI. Feel free to merge |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Some more fixes, some commands are still broken and will require more work: