fix(router): remove duplicated getOutlet function (#39764)

cexbrayat · AndrewKushnir · commit df231ad57252 · 2020-11-20T08:31:17.000-08:00
The codebase currently contains two `getOutlet` functions, and they can end up in the bundle of an application. A recent commit 6fbe219 tipped us off as it introduced several `noop` occurrences in the golden symbol files. After investigating with @petebacondarwin, we decided to remove the duplicated functions. This probably shaves only a few bytes, but this commit removes the duplicated functions, by always using the one in `router/src/utils/config`. PR Close #39764
diff --git a/packages/core/test/bundling/router/bundle.golden_symbols.json b/packages/core/test/bundling/router/bundle.golden_symbols.json
@@ -1379,9 +1379,6 @@
   {
     "name": "getOutlet"
   },
-  {
-    "name": "getOutlet"
-  },
   {
     "name": "getOwnDefinition"
   },
diff --git a/packages/router/src/recognize.ts b/packages/router/src/recognize.ts
@@ -14,6 +14,7 @@ import {ActivatedRouteSnapshot, inheritedParamsDataResolve, ParamsInheritanceStr
 import {defaultUrlMatcher, PRIMARY_OUTLET} from './shared';
 import {mapChildrenIntoArray, UrlSegment, UrlSegmentGroup, UrlTree} from './url_tree';
 import {forEach, last} from './utils/collection';
+import {getOutlet} from './utils/config';
 import {TreeNode} from './utils/tree';
 
 class NoMatch {}
@@ -328,10 +329,6 @@ function emptyPathMatch(
   return r.path === '' && r.redirectTo === undefined;
 }
 
-function getOutlet(route: Route): string {
-  return route.outlet || PRIMARY_OUTLET;
-}
-
 function getData(route: Route): Data {
   return route.data || {};
 }

Original file line number	Diff line number	Diff line change
`@@ -1379,9 +1379,6 @@`
`1379`	`1379`	`{`
`1380`	`1380`	`"name": "getOutlet"`
`1381`	`1381`	`},`
`1382`		`- {`
`1383`		`- "name": "getOutlet"`
`1384`		`- },`
`1385`	`1382`	`{`
`1386`	`1383`	`"name": "getOwnDefinition"`
`1387`	`1384`	`},`