✨ [Story Preview] Enable stories to play when in preview mode #38121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coreymasanto
commented
Apr 20, 2022
|
Hey @gmajoulet, @newmuis! These files were changed: |
jridgewell
requested changes
Apr 20, 2022
…ve the unnecessary hasBeenPreviewed()
…y use of hasBeenPreviewed()
jridgewell
approved these changes
Apr 21, 2022
gmajoulet
approved these changes
Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PREVIEWvisibility state #37129The layout logic of
amp-storyis designed to block until the story has reached thevisiblevisibility state. However, the story should also layout and play in the newly introducedpreviewvisibility state.