🖍 [Page Attachments] Add the 'Read more' string for translation #37991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en the attachment's owner has been set to itself
|
Hey @gmajoulet, @newmuis! These files were changed: |
mszylkowski
approved these changes
Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #36724, we are updating the default CTA for page attachments from "Swipe up" to "Read more". This PR adds this new "Read more" string in the appropriate places to be translated.
This string was previously added in this PR, but it was later mistakenly deprecated due to lack of use. Note that this new string will go unused until it has been translated, at which point I will create another PR to replace usages of "Swipe up" with "Read more".