Fix invalid use for ConcurrentIterableIterator#101
Merged
Conversation
Also added the test for php engine iterables. The exception was not caught in tests because instance of ConcurrentIterableIterator was always passed to ReadableIterableStream constructor in tests and never hit the branch for other type of iterables.
Member
|
/**
* @param iterable<mixed, string> $iterable
*/
public function __construct(iterable $iterable)
{
$this->iterator = $iterable instanceof ConcurrentIterator
? $iterable
: Pipeline::fromIterable($iterable)->getIterator();
$this->onClose = new DeferredFuture;
} |
Contributor
Author
|
I noticed your comment just now... Well, carry on and happy holidays! |
Member
|
Yep, sorry I'm not usually that impatient, but I wanted to work on this and dependent libraries this weekend and this was actually holding things up. Thanks and happy holidays to you too! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also added the test for php engine iterables. The exception was not caught in tests because instance of ConcurrentIterableIterator was always passed to ReadableIterableStream constructor in tests and never hit the branch for other type of iterables.