Skip to content

Commit bcdea48

Browse files
author
Andrejs Kalnačs
committed
Test which covers TestNG suite with parameter, now in new Allure report this is shown as one tests with with two runs (one rerun), but actually this is not true, as these are different tests (because they have different parameters).
In old Allure that was distinguished by test case name, so assert is made based on how it was in previous Allure
1 parent f78ee3d commit bcdea48

4 files changed

Lines changed: 58 additions & 0 deletions

File tree

‎allure-testng/src/test/java/io/qameta/allure/testng/FeatureCombinationsTest.java‎

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -311,6 +311,19 @@ public void multipleSuites() {
311311
assertContainersChildren(secondSuiteName, testContainers, getUidsByName(testContainers, secondTagName));
312312
}
313313

314+
@Test(description = "Before Suite Parameter")
315+
public void testBeforeSuiteParameter() {
316+
runTestNgSuites("suites/parameterized-suite1.xml", "suites/parameterized-suite2.xml");
317+
List<TestResult> testResults = results.getTestResults();
318+
assertThat(testResults)
319+
.hasSize(2)
320+
.extracting(TestResult::getFullName)
321+
.containsExactly(
322+
"io.qameta.allure.testng.samples.SuiteParametersTest.simpleTest[param=first]",
323+
"io.qameta.allure.testng.samples.SuiteParametersTest.simpleTest[param=second]"
324+
);
325+
}
326+
314327
@Test(description = "Parallel methods")
315328
public void parallelMethods() {
316329
String before1 = "io.qameta.allure.testng.samples.ParallelMethods.beforeMethod";

‎allure-testng/src/test/java/io/qameta/allure/testng/samples/SuiteParameterTest.java‎

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
package io.qameta.allure.testng.samples;
2+
3+
/*
4+
@author Andrejs Kalnacs [email protected]
5+
*/
6+
import org.testng.ITestContext;
7+
import org.testng.annotations.BeforeSuite;
8+
import org.testng.annotations.Parameters;
9+
import org.testng.annotations.Test;
10+
11+
public class SuiteParameterTest {
12+
@Parameters("parameter")
13+
@BeforeSuite
14+
public void beforeSuite(String parameter, ITestContext context) {
15+
context.getCurrentXmlTest().addParameter("param", parameter);
16+
}
17+
18+
@Test()
19+
public void simpleTest() {
20+
}
21+
}

‎allure-testng/src/test/resources/suites/parameterized-suite1.xml‎

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<!DOCTYPE suite SYSTEM "http://testng.org/testng-1.0.dtd" >
3+
4+
<suite name="Suite with parameter">
5+
<parameter name="parameter" value="first" />
6+
<test name="Parameter test">
7+
<classes>
8+
<class name="io.qameta.allure.testng.samples.SuiteParameterTest">
9+
</class>
10+
</classes>
11+
</test>
12+
</suite>

‎allure-testng/src/test/resources/suites/parameterized-suite2.xml‎

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<!DOCTYPE suite SYSTEM "http://testng.org/testng-1.0.dtd" >
3+
4+
<suite name="Suite with parameter">
5+
<parameter name="parameter" value="second" />
6+
<test name="Parameter test">
7+
<classes>
8+
<class name="io.qameta.allure.testng.samples.SuiteParameterTest">
9+
</class>
10+
</classes>
11+
</test>
12+
</suite>

0 commit comments

Comments
 (0)