Add regression test for cppcheck-opensource#7798 (cppcheck-opensource#1847)

rikardfalkeborn · danmar · commit b970606c93d2 · 2019-06-15T11:34:06.000+02:00
Trac ticket cppcheck-opensource#7798 was fixed in 3f1e2b4 (More conservative fallback for function overload matching). Add a test to avoid regressions.
diff --git a/test/testbool.cpp b/test/testbool.cpp
@@ -60,6 +60,7 @@ class TestBool : public TestFixture {
         TEST_CASE(checkComparisonOfFuncReturningBool4);
         TEST_CASE(checkComparisonOfFuncReturningBool5);
         TEST_CASE(checkComparisonOfFuncReturningBool6);
+        TEST_CASE(checkComparisonOfFuncReturningBool7); // #7798 overloaded functions
         TEST_CASE(checkComparisonOfBoolWithBool);
 
         // Converting pointer addition result to bool
@@ -726,6 +727,19 @@ class TestBool : public TestFixture {
         ASSERT_EQUALS("", errout.str());
     }
 
+    // Integration test
+    void checkComparisonOfFuncReturningBool7() { // #7798
+        check("bool eval(double *) { return false; }\n"
+              "double eval(char *) { return 1.0; }\n"
+              "int main(int argc, char *argv[])\n"
+              "{\n"
+              "  if ( eval(argv[1]) > eval(argv[2]) )\n"
+              "    return 1;\n"
+              "  return 0;\n"
+              "}");
+        ASSERT_EQUALS("", errout.str());
+    }
+
     void checkComparisonOfBoolWithBool() {
         const char code[] = "void f(){\n"
                             "    int temp = 4;\n"
