Fix #10770 FP noConstructor with function pointer member (cppcheck-opensource#3751)

chrchr-github · web-flow · commit 78dd29ada3e6 · 2022-03-03T13:56:24.000+01:00
diff --git a/lib/checkclass.cpp b/lib/checkclass.cpp
@@ -164,7 +164,7 @@ void CheckClass::constructors()
         if (scope->numConstructors == 0 && printStyle && !usedInUnion) {
             // If there is a private variable, there should be a constructor..
             for (const Variable &var : scope->varlist) {
-                if (var.isPrivate() && !var.isStatic() && !var.isInit() &&
+                if (var.isPrivate() && !var.isStatic() && !var.isInit() && !var.hasDefault() &&
                     (!var.isClass() || (var.type() && var.type()->needInitialization == Type::NeedInitialization::True))) {
                     noConstructorError(scope->classDef, scope->className, scope->classDef->str() == "struct");
                     break;
diff --git a/test/testconstructors.cpp b/test/testconstructors.cpp
@@ -102,6 +102,7 @@ class TestConstructors : public TestFixture {
         TEST_CASE(noConstructor11); // ticket #3552
         TEST_CASE(noConstructor12); // #8951 - member initialization
         TEST_CASE(noConstructor13); // #9998
+        TEST_CASE(noConstructor14); // #10770
 
         TEST_CASE(forwardDeclaration); // ticket #4290/#3190
 
@@ -699,6 +700,17 @@ class TestConstructors : public TestFixture {
         ASSERT_EQUALS("", errout.str());
     }
 
+    void noConstructor14() { // #10770
+        check("typedef void (*Func)();\n"
+              "class C {\n"
+              "public:\n"
+              "    void f();\n"
+              "private:\n"
+              "    Func fp = nullptr;\n"
+              "};\n");
+        ASSERT_EQUALS("", errout.str());
+    }
+
     // ticket #4290 "False Positive: style (noConstructor): The class 'foo' does not have a constructor."
     // ticket #3190 "SymbolDatabase: Parse of sub class constructor fails"
     void forwardDeclaration() {
