Skip to content

Commit e8016df

Browse files
committed
fixed some linting rules and updated some instructions. More to come.
1 parent dc8c373 commit e8016df

File tree

5 files changed

+24
-13
lines changed

5 files changed

+24
-13
lines changed

.eslintrc.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
"arrow-body-style": 0,
1414
"no-unused-vars": 0,
1515
"no-useless-constructor": 0,
16-
"import/no-unresolved": 0
16+
"import/no-unresolved": 0,
17+
"comma-dangle": "off"
1718
}
1819
}

README.md

Lines changed: 20 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,24 @@
11
# JavaScript I
22

3-
## Instructions
3+
## Project initialization
44

5-
Do not use any of the built in Javascript Array methods like .forEach .map etc. If you'd like feel free to reuse any of your functions along the way though!
6-
7-
#### Fork and clone this repo.
8-
* Clone this repository and navigate into it.
5+
* `Fork and Clone` this repository and cd into it.
96
* Run the command `npm i` to install needed node packages.
10-
* Run the command `npm test` to run the tests.
11-
* Work through the files and make the tests pass.
12-
* Suggested order: `callbacks.js`, `arrays.js`, `objects.js`, `closure.js`.
13-
* Submit a pull request when you are finished and we will review your code.
7+
* **JUST** a _reminder_ this command runs a script on your machine based on the `package.json` file you have installed in your project. By running this command, you're telling your project to head over to `npm.org` and download all of the packages you need for this project.
8+
## Instructions
9+
* This project is designed to carry over from JavaScript I through JavaScript II.
10+
* Please complete the project files in this order: `variables.js` `callbacks.js` `arrays.js` `objects.js` and finally `closure.js`.
11+
* In each project file you'll see a series of problems to work through,.
12+
* When you feel like you've completed the problem, be sure to run, `npm test <file name>` to get see if your code works properly... and to check if you have any linting errors.
13+
* Work until you have all of the tests passing.
14+
## Running the tests
15+
Example:
16+
17+
```
18+
npm test arrays
19+
20+
-> executes all of the tests in the `src/tests/arrays.tests.js file`
21+
22+
npm test closure
23+
-> executes all of the tests in the `src/tests/closure.tests.js file`
24+
```

src/callbacks.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
/* eslint-disable */
2-
31
const firstItem = (arr, cb) => {
42
// firstItem passes the first item of the given array to the callback function.
53
};
@@ -41,5 +39,5 @@ module.exports = {
4139
sumNums,
4240
multiplyNums,
4341
contains,
44-
removeDuplicates,
42+
removeDuplicates
4543
};

src/variables.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
// TODO: fill this in with some awesome variable examples using let, const and var.

tests/variables.test.js

Whitespace-only changes.

0 commit comments

Comments
 (0)