Add a fallback for pluralRules #566
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@bakhbk What is the problem this PR is solving? |
Author
on line 138, an object is expected to be returned. But the "pluralRules" map is missing the required keys. As a result, null is returned instead of an object. Then a crash occurs. I removed the unsafe call "!", added a default return value. |
Collaborator
|
@bakhbk I see, this change definitely makes sense, thanks for submitting it! There are two things necessary for this to get merged:
|
bw-flagship
requested changes
Aug 30, 2023
Collaborator
bw-flagship
left a comment
bw-flagship
left a comment
There was a problem hiding this comment.
- The unrelated changes (blank lines, change in pubspec) should be removed
- There should be at least one Unit test covering this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.