Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dbrans/browserstack-cli
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: airportyh/browserstack-cli
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 14 commits
  • 3 files changed
  • 6 contributors

Commits on Aug 10, 2013

  1. Enable a timeout to be sent to the tunnel 

    I have separately added support to the tunnel for receiving the timeout in the options.

I have used the same -t switch, but documented it separately in the tunnel command. Perhaps the documentation of the main -t switch should be updated to mention it's also for tunnel timeout?

I needed to extend the timeout of the tunnel for my environment and as it's an arbitrary measurement it seems like a good idea to make it an option.
    @karlvr
    karlvr committed Aug 10, 2013
    Configuration menu
    Copy the full SHA
    4c86d55 View commit details
    Browse the repository at this point in the history

  2. Kill the tunnel when the cli process is killed 

    We call hangOnTillExit before the tunnel opens so that if the process is killed during the connecting phase the tunnel is still killed.
    @karlvr
    karlvr committed Aug 10, 2013
    Configuration menu
    Copy the full SHA
    0334e88 View commit details
    Browse the repository at this point in the history

  3. Implement the --os command line switch 

    The --os command-line switch didn't appear to be implemented. Obviously this requires support in browseroverfow which I'm submitting separately.

The OS needs to be specified as name:version, e.g. "Windows:XP" or "OS X:Mountain Lion". That's a bit clumsy looking, but it fits with the browser version style and it sort of matches the output from the "browsers" command.

Perhaps it could be supported with the "Name (Version)" style. If you like the sound of that I would be happy to implement that for both OS and browser.
    @karlvr
    karlvr committed Aug 10, 2013
    Configuration menu
    Copy the full SHA
    3aeb587 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2013

  1. Merge pull request #2 from karlvr/tunnel-timeouts 

    Enable a timeout to be sent to the tunnel
    @airportyh
    airportyh committed Aug 13, 2013
    Configuration menu
    Copy the full SHA
    c8265e2 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #1 from karlvr/launch-with-os 

    Implement the --os command line switch
    @airportyh
    airportyh committed Aug 13, 2013
    Configuration menu
    Copy the full SHA
    fd1508e View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2013

  1. Updated README.md to conform with actual usage information

    @vrutberg
    vrutberg committed Oct 16, 2013
    Configuration menu
    Copy the full SHA
    3a8a041 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #3 from vrutberg/master 

    Updated README.md to conform with actual usage information
    @airportyh
    airportyh committed Oct 16, 2013
    Configuration menu
    Copy the full SHA
    c5b484d View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2013

  1. add timeout setting to launchWorker

    @jfromaniello
    jfromaniello committed Oct 30, 2013
    Configuration menu
    Copy the full SHA
    5d5054d View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2013

  1. Fix issue with: Validation Failed - can't be blank

    @jfromaniello
    jfromaniello committed Oct 31, 2013
    Configuration menu
    Copy the full SHA
    cc292be View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2013

  1. 0.3.0

    @airportyh
    airportyh committed Nov 5, 2013
    Configuration menu
    Copy the full SHA
    795f697 View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2014

  1. There is no 'os_name' flag in neither Browseroverflow nor the Browser… 

    …stack APIs. The correct flag to use for the Operating System name is simply 'os'.
    @anilsson-atex
    anilsson-atex committed Jan 7, 2014
    Configuration menu
    Copy the full SHA
    5ee1104 View commit details
    Browse the repository at this point in the history

  2. 0.3.1

    @jfromaniello
    jfromaniello committed Jan 7, 2014
    Configuration menu
    Copy the full SHA
    619803c View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2015

  1. Upgrade to use browseroverflow 0.3.0

    @vedharish
    vedharish committed Dec 10, 2015
    Configuration menu
    Copy the full SHA
    9584226 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2015

  1. Merge pull request #6 from vedharish/browseroverflow_0_3 

    Upgrade to use browseroverflow 0.3.0
    @airportyh
    airportyh committed Dec 11, 2015
    Configuration menu
    Copy the full SHA
    fedd52b View commit details
    Browse the repository at this point in the history
Loading