Skip to content

move dispatcher in kwargs #1639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
RootShinobi wants to merge 1 commit into
base: dev-3.x
Choose a base branch
from
Open

move dispatcher in kwargs #1639

RootShinobi wants to merge 1 commit into from

Conversation

@RootShinobi
Copy link
Contributor

@RootShinobi RootShinobi commented Feb 14, 2025

Description

moved dispatcher as kwarg to feed_update

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Operating System:
  • Python version:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@github-actions github-actions bot added the 3.x Issue or PR for stable 3.x version label Feb 14, 2025
@github-actions
Copy link

github-actions bot commented Feb 14, 2025

❌ Changelog is required!

You need to add a brief description of the changes to the CHANGES directory.

Changes file should be named like <issue or PR number>.<category>.rst,
example 1234.bugfix.rst where 1234 is the PR or issue number and bugfix is the category.

The content of the file should be a brief description of the changes in
the PR in the format of a description of what has been done.

Possible categories are: feature, bugfix, doc, removal and misc.

@codecov
Copy link

codecov bot commented Feb 14, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (6e81294) to head (9315ab5).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           dev-3.x     #1639   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          484       484           
  Lines        12206     12206           
=========================================
  Hits         12206     12206
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
aiogram/dispatcher/dispatcher.py 100.00% <ø> (ø)

@JrooTJunior
Copy link
Member

JrooTJunior commented Mar 1, 2025

Any news?

changelog is required

JrooTJunior
JrooTJunior requested changes Mar 2, 2025
View reviewed changes
aiogram/dispatcher/dispatcher.py
)

workflow_data = {
"dispatcher": self,
Copy link
Member

@JrooTJunior JrooTJunior Mar 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

startup/shutdown hooks should also have access to the Disaptcher, so you can't remove this line.

@JrooTJunior JrooTJunior requested a review from Copilot April 5, 2025 19:12
Copilot AI reviewed Apr 5, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@JrooTJunior JrooTJunior JrooTJunior requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

3.x Issue or PR for stable 3.x version

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@RootShinobi @JrooTJunior