Conversation
pepoluan
left a comment
pepoluan
left a comment
There was a problem hiding this comment.
A thot about that ... 🙃
There was a problem hiding this comment.
I would split the piece of text explaining that we're replacement for smtpd into a separate paragraph, optionally with some kind of highlight / callout.
|
I enabled building PR previews @ RTD but it fails currently because the RTD config file needs to be updated: https://readthedocs.org/projects/aiosmtpd/builds/23289246/. The GHA linting is failing is unrelated either, because of the unpinned flake8 plugin version, I suppose. |
Filed an issue for this with pointers: #393. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #384 +/- ##
==========================================
- Coverage 98.14% 98.12% -0.02%
==========================================
Files 22 22
Lines 5646 5646
Branches 755 755
==========================================
- Hits 5541 5540 -1
- Misses 68 70 +2
+ Partials 37 36 -1 ☔ View full report in Codecov by Sentry. |
|
@waynew needs conflict resolution |
3 participants
See #320 - I did a quick audit and changed the couple of things that could use it. I did not confirm whether or not any of the code samples in the docs have any changes that are inconsistent with the current codebase... My hope is that they were already update and tested 😅
Anyway... this may or may not completely resolve #320.