pass the magic-file parameter around the module functions#56
Closed
jbremer wants to merge 1 commit intoahupp:masterfrom
Closed
pass the magic-file parameter around the module functions#56jbremer wants to merge 1 commit intoahupp:masterfrom
jbremer wants to merge 1 commit intoahupp:masterfrom
Conversation
Owner
|
Since from_buffer/from_file memoize their result, this is going to produce inconsistent results if you switch the file mid-execution. I'd prefer that this get solved either by globally overriding the file (there's an env var IIRC though I don't remember it off the top of my head), or by using the Magic class directly. |
Author
|
I was using the Let me know if you care to reconsider this PR, otherwise I guess it's also fine ;-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.