breaking: Remove sinon.defaultConfig and related modules#2565
Merged
fatso83 merged 4 commits intosinonjs:mainfrom Nov 2, 2023
Merged
breaking: Remove sinon.defaultConfig and related modules#2565fatso83 merged 4 commits intosinonjs:mainfrom
fatso83 merged 4 commits intosinonjs:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2565 +/- ##
==========================================
- Coverage 96.05% 96.05% -0.01%
==========================================
Files 41 40 -1
Lines 1928 1927 -1
==========================================
- Hits 1852 1851 -1
Misses 76 76
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
default-config and get-config are leftovers from when Sinon shipped with sinon.test (now the independent NPM module 'sinon-test'). These serve no purpose internally, and really have no purpose but to help sinon-test create a base default. If needed, these can be copied into the sinon-test project. No projects should depend on these (my assumption), but since it is a change of the API we mark it as a breaking change fixes sinonjs#2561
It seemed like the the 'injectInto' option would expose most props by default. This was not the case. That was formerly hidden by using the getConfig call that added props that were never used in the actual implementation. Added another test to make this more explicit. Will add docs on this.
This was added in Sinon 0.6 but has never been documented
fatso83
force-pushed
the
remove-default-config
branch
from
9911e05 to
94ee6d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
default-configandget-configare leftovers from when Sinon shipped with sinon.test (now the independent NPM module'sinon-test').
These serve no purpose internally, and really have no purpose but to help sinon-test create a base default. If needed, these can be copied into the sinon-test project. No projects should depend on these (my assumption), but since it is a change of the API we mark it as a breaking change
When working with these I found out that some things had never been documented, so added docs for that.
fixes #2561