Fixed memory leak with shared V8 runtimes (Issue ClearFoundry#107).

ClearScriptLib · ClearScriptLib · commit 41036a3cb82a · 2016-05-09T13:36:59.000-04:00
diff --git a/ClearScript/V8/ClearScriptV8/V8ContextImpl.cpp b/ClearScript/V8/ClearScriptV8/V8ContextImpl.cpp
@@ -737,6 +737,7 @@ V8ContextImpl::~V8ContextImpl()
     Dispose(m_hHostIteratorTemplate);
     Dispose(m_hHostDelegateTemplate);
     Dispose(m_hHostObjectTemplate);
+	Dispose(m_hTerminationException);
     Dispose(m_hAccessToken);
     Dispose(m_hAccessTokenName);
     Dispose(m_hCachePropertyName);
diff --git a/ClearScriptTest/BugFixTest.cs b/ClearScriptTest/BugFixTest.cs
@@ -1901,6 +1901,35 @@ public void BugFix_VBScript_PropertyPut_CrossEngine_VBScript()
             BugFix_VBScript_PropertyPut_CrossEngine();
         }
 
+        [TestMethod, TestCategory("BugFix")]
+        public void BugFix_SharedV8RuntimeLeak()
+        {
+            using (var runtime = new V8Runtime())
+            {
+                using (runtime.CreateScriptEngine())
+                {
+                }
+
+                runtime.CollectGarbage(true);
+                var heapSize = runtime.GetHeapInfo().TotalHeapSize;
+
+                for (var i = 0; i < 500; i++)
+                {
+                    using (runtime.CreateScriptEngine())
+                    {
+                    }
+
+                    if ((i % 25) == 24)
+                    {
+                        runtime.CollectGarbage(true);
+                    }
+                }
+
+                runtime.CollectGarbage(true);
+                Assert.IsFalse(runtime.GetHeapInfo().TotalHeapSize > (heapSize * 1.5));
+            }
+        }
+
         // ReSharper restore InconsistentNaming
 
         #endregion
