Generalized regression monitoring for PerfPipeline.#6443
Open
MattyWeee123 wants to merge 30 commits intoadoptium:masterfrom
Open
Generalized regression monitoring for PerfPipeline.#6443MattyWeee123 wants to merge 30 commits intoadoptium:masterfrom
MattyWeee123 wants to merge 30 commits intoadoptium:masterfrom
Conversation
metricConfig2JSON.py parses and rearranges BenchmarkMetrics.js into JSON. initBenchmarkMetrics.py generates templates for a groovy aggregate metric map and a single test map for archiving individual test/baseline child jobs. benchmarkMetrics.py updates a single test map with the metric value for a run. testList is used to generalize regression monitoring and EXIT_EARLY for child jobs that run multiple tests (removing from testList will have both parent and child ignore the removed test). Using specific rhel9 machine to run the python scripts and getPythonDependencies uses curl to retrieve the relevant python scripts. Fixes: adoptium#6418, adoptium#6355 Signed-off-by: Matthew Wei <[email protected]>
… next test; only remove from list if no regression is found across all metrics
llxia
reviewed
Jul 22, 2025
Contributor
|
Thanks @MattyWeee123 . Have you tried to run this in https://ci.adoptium.net/view/Test_grinder/job/Perf_Pipeline/? If so, please provide the link. Thanks |
…ther one has issues finding python3
Contributor
Author
llxia
reviewed
Jul 30, 2025
Contributor
|
@MattyWeee123 Will need a rebase (or that merge conflict fixed) |
MattyWeee123
force-pushed
the
issue6418
branch
from
838b5aa to
f0c6043
Compare
karianna
approved these changes
Aug 10, 2025
Contributor
|
https://ci.adoptium.net/view/Test_grinder/job/Perf_Pipeline/178/ to check that resolving merge conflicts did not alter behaviour. |
smlambert
reviewed
Dec 3, 2025
smlambert
reviewed
Dec 3, 2025
smlambert
reviewed
Dec 3, 2025
smlambert
reviewed
Dec 3, 2025
Add extra brace
smlambert
requested changes
Dec 3, 2025
Contributor
smlambert
left a comment
smlambert
left a comment
There was a problem hiding this comment.
Putting a block on this, as I have pushed some commits that I will need to remove/fix in the process of resolving merge conflicts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
metricConfig2JSON.py parses and rearranges BenchmarkMetrics.js into JSON. initBenchmarkMetrics.py generates templates for a groovy aggregate metric map and a single test map for archiving individual test/baseline child jobs. benchmarkMetrics.py updates a single test map with the metric value for a run.
testList is used to generalize regression monitoring and EXIT_EARLY for child jobs that run multiple tests (removing from testList will have both parent and child ignore the removed test).
Using specific rhel9 machine to run the python scripts and getPythonDependencies uses curl to retrieve the relevant python scripts.
BenchmarkMetric.js needs to be updated (lusearch-fix should be lusearch, tomcat is not there so the script thinks it should grab all dacapo metrics for tomcat which is not true, ...)
Fixes: #6418, #6355