-
Notifications
You must be signed in to change notification settings - Fork 7.5k
Fix typos [Croatian] #13628
Fix typos [Croatian] #13628
Conversation
|
@petetnt I'd be pleased if you merged this pull request. |
|
Cool! Tagging @diomed made changes last time. If you have the time to review these changes that would be neat! |
|
|
||
| // Application preferences corrupt error strings | ||
| "ERROR_PREFS_CORRUPT_TITLE" : "Greška kod čitanja preferencija", | ||
| "ERROR_PREFS_CORRUPT_TITLE" : "Greška prilikom učitanja preferencija", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
učitavanja
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would need access to patch-1 branch in order to edit the commit. Can you do that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how did u edit this in the first place? didn't you clone the repo? if you did, you should have that branch. that is your working branch. I hope u didn't delete it before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really weird that the source shows unknown repository 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not clone it (there was no need) as I created commit directly via browser editor. If you can not edit the commit either I will repost.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@petetnt u can merge this, then fix that 1 word. I hope that's not a problem. Everything else is fine, and more in the spirit of Croatian language, I guess.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@diomed This Brackets README page describes how to make updates to branches created directly in browser: https://github.com/adobe/brackets/tree/master/src/nls#updating-existing-branch-and-pull-request
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@redmunds We have unknown repo instead of known fork path.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the fork got destroyed at some point, but it's not a big deal. We can merge this and fix the one type in the next PR.
|
Merging this, lets fix the leftover typo in another PR. Thanks for your first contribution to adobe/brackets @dbaric! |
No description provided.