Correct log when python-version-file unspecified#429
Closed
Kurt-von-Laven wants to merge 2 commits intoactions:mainfrom
Closed
Correct log when python-version-file unspecified#429Kurt-von-Laven wants to merge 2 commits intoactions:mainfrom
python-version-file unspecified#429Kurt-von-Laven wants to merge 2 commits intoactions:mainfrom
Conversation
Contributor
|
Hello @Kurt-von-Laven. Thank you for your pull request. Could you please run the |
Contributor
Author
|
Thanks for the tip; done! Might be worth adding this to a contributing guide or the pull request template. |
Contributor
Author
|
My gut feeling is that the failures are CI flakiness and unrelated to my changes, but please let me know if I am missing something. |
Contributor
|
Hello @Kurt-von-Laven. I think your changes are not related to CI failures. |
|
@Kurt-von-Laven, I believe your PR #431 will resolve this issue as well, no need for this PR. |
Contributor
Author
|
Yes, that is true. I made this PR before I was aware of the other issue. I will close this one pending the other’s acceptance. |
Set the versionFile variable to its default value of .python-version when it's not specified. This corrects the log statement to read: "Resolved .python-version as x.y.z" rather than "Resolved as x.y.z."
Contributor
Author
|
Superseded by #431. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Set the
versionFilevariable to its default value of.python-versionwhen it's not specified. This corrects the log statement to read: "Resolved .python-version as x.y.z" rather than "Resolved as x.y.z."Related issue:
Fixes #428.
Check list: