Merged
Conversation
thboop
force-pushed
the
swapToEnvFiles
branch
from
24417a1 to
f5338d5
Compare
thboop
force-pushed
the
swapToEnvFiles
branch
2 times, most recently
from
c910bc0 to
13d38a5
Compare
thboop
force-pushed
the
swapToEnvFiles
branch
from
13d38a5 to
5590df7
Compare
thboop
force-pushed
the
swapToEnvFiles
branch
from
3095a47 to
d36cf58
Compare
Member
|
Probably good to bump the minimum here to ^1.2.6 https://github.com/actions/setup-node/blob/main/package.json#L26 |
Member
|
Outside of that, looks good. |
bryanmacfarlane
requested changes
Oct 1, 2020
Member
bryanmacfarlane
left a comment
bryanmacfarlane
left a comment
There was a problem hiding this comment.
feel free to merge after the suggested change
tcamde
added a commit
to tcamde/setup-node
that referenced
this pull request
Oct 6, 2020
Swap to env files (actions#200)
Krenair
added a commit
to alphagov/re-rotas
that referenced
this pull request
Nov 17, 2020
…tup-node https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/ contains: `Action authors who are using the toolkit should update the @actions/core package to v1.2.6 or greater to get the updated addPath and exportVariable functions.` and `Action and workflow authors who are setting environment variables via STDOUT should update any usage of the set-env and add-path workflow commands to use the new environment files.` Which setup-node appear to have done in actions/setup-node#200 The commits for which have been tagged v2.1.2.
Krenair
added a commit
to alphagov/re-rotas
that referenced
this pull request
Nov 17, 2020
…tup actions https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/ contains: `Action authors who are using the toolkit should update the @actions/core package to v1.2.6 or greater to get the updated addPath and exportVariable functions.` and `Action and workflow authors who are setting environment variables via STDOUT should update any usage of the set-env and add-path workflow commands to use the new environment files.` Which setup-node appear to have done in actions/setup-node#200 - the commits for which have been tagged v2.1.2. And which setup-ruby appear to have done in ruby/setup-ruby#91 - the commits for which have been tagged v1.46.1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The newest toolkit version uses Environment files to communicate with the Runner. This pr moves towards the new way of communicating with the runner and updates the toolkit version if appropriate.