Skip to content

Conversation

@OmkarPh
Copy link
Collaborator

@OmkarPh OmkarPh commented May 10, 2023

Fixes #565

@OmkarPh OmkarPh linked an issue May 14, 2023 that may be closed by this pull request
Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OmkarPh looks good thanks++
I've tested out with the scan in the issue and this works as expected. Couple of follow ups:

  1. Possible UI improvements?
    license-clues
    The horizontal and vertical scrollbars are present always here, on the left pane.
    workbench-packages-feel
    In packages view these scrollbars are only present when we have a lot of packages/dependencies or we expand the dependencies and there is scrolling.
    IMHO the scrollbars should only be present when scrolling is possible.
    This is also present in other views like the packages explorer.

  2. Grouping same license clues together.

This has to happen from the toolkit side, I'm thinking of adding a new field in the license clues : for_detection as a refinement to be able to group these together. This will be useful where there are a bunch of repeating license clues. We'll then do the needful here to have them similarly as the matches table in license detections then.

@OmkarPh
Copy link
Collaborator Author

OmkarPh commented Jun 8, 2023

I couldn't reproduce the ugly empty scroll panes on my system (maybe it's OS specific 🤔 )
I've pushed a trial fix, please test it on your system

@AyanSinhaMahapatra
Copy link
Member

maybe it's OS specific thinking )

Yeah thought so, these are fixed now! See screenshots below.

ugly-bars-fixed-license
ugly-bars-fixed-packages

Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@OmkarPh
Copy link
Collaborator Author

OmkarPh commented Jun 8, 2023

maybe it's OS specific thinking )

Yeah thought so, these are fixed now! See screenshots below.

thanks 😄

@OmkarPh OmkarPh merged commit 4c054cf into v4.0-react-typescript Jun 8, 2023
@AyanSinhaMahapatra AyanSinhaMahapatra deleted the feature/license_clues branch October 25, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Also show license clues

2 participants