chore: Add Dubnium codename to schedule.json#352
Closed
nschonni wants to merge 1 commit intonodejs:masterfrom
Closed
chore: Add Dubnium codename to schedule.json#352nschonni wants to merge 1 commit intonodejs:masterfrom
nschonni wants to merge 1 commit intonodejs:masterfrom
Conversation
cjihrig
approved these changes
Jul 1, 2018
Member
|
@jasnell want your input as I saw your comment somewhere else that the codename only comes into effect when the release goes LTS. |
styfle
approved these changes
Jul 18, 2018
KSH-code
approved these changes
Jul 19, 2018
Contributor
|
+1. Would approve but don't want to add a green check. Would be fantastic if this could be landed if there's not blockers 😅 |
Member
|
The code name does not apply until the branch goes into LTS. This won't be able to land until then. |
styfle
approved these changes
Aug 16, 2018
mhdawson
approved these changes
Aug 22, 2018
Member
mhdawson
left a comment
mhdawson
left a comment
There was a problem hiding this comment.
LGTM provided we wait until 10 is LTS.
Fishrock123
approved these changes
Sep 13, 2018
|
does anyone know when node 10 is going to become LTS? |
|
@iamstarkov apparently decided to be |
Contributor
|
This ended up getting fixed in another pr, thank you for opening this though! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although the LTS hasn't started, the name appears to be used in other parts of the repo already