Skip to content

chore(test): Increase test coverage across multiple modules #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
holtskinner merged 13 commits into from
Jun 12, 2025
Merged

chore(test): Increase test coverage across multiple modules #169

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
dc5f91b
chore(test): Increase test coverage across multiple modules
holtskinner Jun 10, 2025
891a79c
Fix missing type and spelling
holtskinner Jun 10, 2025
86d1704
Update Code Coverage
holtskinner Jun 10, 2025
4ccbe20
Fix forbidden pattern
holtskinner Jun 10, 2025
d227dde
Fix coveragerc
holtskinner Jun 10, 2025
4339f8d
Add more tests
holtskinner Jun 11, 2025
9b3e847
Remove problematic tests
holtskinner Jun 11, 2025
694eb63
Remove more tests
holtskinner Jun 11, 2025
5fca4ea
Set coverage level to 85%
holtskinner Jun 11, 2025
6b3e936
Spelling
holtskinner Jun 11, 2025
b9b52ea
Fix test edited by Jules
holtskinner Jun 11, 2025
da4226b
Merge branch 'main' into jules_wip_14959778467806306980
holtskinner Jun 11, 2025
72e334b
Merge branch 'main' into jules_wip_14959778467806306980
holtskinner Jun 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove more tests
  • Loading branch information
@holtskinner
holtskinner committed Jun 11, 2025
commit 694eb63e2f1c0373aa384ff1be10a8f07de8c53d
48 changes: 0 additions & 48 deletions tests/utils/test_proto_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
from a2a import types
from a2a.grpc import a2a_pb2
from a2a.utils import proto_utils
from a2a.utils.errors import ServerError


# --- Test Data ---
Expand Down Expand Up @@ -95,9 +94,9 @@
'httpAuth': types.SecurityScheme(
root=types.HTTPAuthSecurityScheme(scheme='bearer')
),
'oidc': types.SecurityScheme(

Check failure on line 97 in tests/utils/test_proto_utils.py

View workflow job for this annotation

GitHub Actions / Check Spelling 

`oidc` is not a recognized word. (unrecognized-spelling)
root=types.OpenIdConnectSecurityScheme(
openIdConnectUrl='http://oidc.url'

Check failure on line 99 in tests/utils/test_proto_utils.py

View workflow job for this annotation

GitHub Actions / Check Spelling 

`oidc` is not a recognized word. (unrecognized-spelling)

Check warning on line 99 in tests/utils/test_proto_utils.py

View workflow job for this annotation

GitHub Actions / Check Spelling 

`oidc` is not a recognized word. (unrecognized-spelling)
)
),
},
Expand All @@ -119,17 +118,6 @@
roundtrip_msg = proto_utils.FromProto.message(proto_msg)
assert roundtrip_msg == sample_message

def test_roundtrip_agent_card(self, sample_agent_card: types.AgentCard):
"""Test conversion of AgentCard to proto and back."""
proto_card = proto_utils.ToProto.agent_card(sample_agent_card)
assert isinstance(proto_card, a2a_pb2.AgentCard)

roundtrip_card = proto_utils.FromProto.agent_card(proto_card)
# Pydantic models with nested dicts/lists might not be equal after roundtrip, so check fields
assert roundtrip_card.name == sample_agent_card.name
assert roundtrip_card.provider == sample_agent_card.provider
assert roundtrip_card.skills == sample_agent_card.skills

def test_enum_conversions(self):
"""Test conversions for all enum types."""
assert (
Expand Down Expand Up @@ -162,42 +150,6 @@
== a2a_pb2.TaskState.TASK_STATE_UNSPECIFIED
)

def test_task_id_params_parsing(self):
"""Test parsing of task and push notification config names."""
cancel_req = a2a_pb2.CancelTaskRequest(name='tasks/task-123')
params = proto_utils.FromProto.task_id_params(cancel_req)
assert params.id == 'task-123'

push_req = a2a_pb2.GetTaskPushNotificationRequest(
name='tasks/task-456/pushNotifications/config-789'
)
params_push = proto_utils.FromProto.task_id_params(push_req)
assert params_push.id == 'task-456'

with pytest.raises(ServerError):
proto_utils.FromProto.task_id_params(
a2a_pb2.CancelTaskRequest(name='invalid/name')
)

with pytest.raises(ServerError):
proto_utils.FromProto.task_id_params(
a2a_pb2.GetTaskPushNotificationRequest(name='invalid/name')
)

def test_task_query_params_parsing(self):
"""Test parsing of GetTaskRequest."""
get_req = a2a_pb2.GetTaskRequest(
name='tasks/task-abc', history_length=10
)
params = proto_utils.FromProto.task_query_params(get_req)
assert params.id == 'task-abc'
assert params.historyLength == 10

with pytest.raises(ServerError):
proto_utils.FromProto.task_query_params(
a2a_pb2.GetTaskRequest(name='invalid/name')
)

def test_oauth_flows_conversion(self):
"""Test conversion of different OAuth2 flows."""
# Test password flow
Expand Down
Loading