Add more flexible documentation options#139
Merged
tiffanymtang merged 13 commits intomainfrom Jan 10, 2023
Merged
Conversation
jpdunc23
requested changes
Jan 10, 2023
Contributor
jpdunc23
left a comment
There was a problem hiding this comment.
Looks good! These new features will be super handy.
I made some comments requesting specific changes and with some thoughts on API design, and it's fine by me if we don't fully address everything in this PR.
Ideally the changes for this PR are fairly quick and we can merge this in soon. But lmk if anything is more work than I realize and I'm happy to pitch in or we can put it off until later.
This was referenced Jan 10, 2023
This was referenced Jan 10, 2023
jpdunc23
approved these changes
Jan 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address the following suggestions from @yanshuotan in issue #132:
create_docs()to allow user to directly edit this .Rmd