Fix bugs with use_*_template(), doc_show, and tidyselect::all_of()#134
Merged
Fix bugs with use_*_template(), doc_show, and tidyselect::all_of()#134
use_*_template(), doc_show, and tidyselect::all_of()#134Conversation
* change functionality of save_experiment to save the active varying across experiment, not the base experiment
tiffanymtang
changed the title
use_*_template() and doc_showuse_*_template(), doc_show, and tidyselect::all_of()
jpdunc23
requested changes
Dec 28, 2022
Contributor
jpdunc23
left a comment
jpdunc23
left a comment
There was a problem hiding this comment.
@tiffanymtang I'll work on the various TODOs I created during the review.
jpdunc23
approved these changes
Jan 9, 2023
Contributor
|
There are inconsistent failures in
|
4 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #128
Closes #130
Closes #135
Also makes modifications to
list_to_tibble_row()andlist_to_tibble()helper functions when handling data frames so that data frames (and hence tibbles) are not unlisted.