Skip to content

Commit 39130d3

Browse files
author
Marcus Linke
committed
fix GoLangMatchFileFilter
1 parent f625b85 commit 39130d3

3 files changed

Lines changed: 13 additions & 7 deletions

File tree

src/main/java/com/github/dockerjava/core/GoLangMatchFileFilter.java

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,17 +10,23 @@
1010

1111
public class GoLangMatchFileFilter extends AbstractFileFilter {
1212

13+
private final File base;
14+
1315
private final List<String> patterns;
1416

1517

16-
public GoLangMatchFileFilter(List<String> patterns) {
18+
public GoLangMatchFileFilter(File base, List<String> patterns) {
1719
super();
20+
this.base = base;
1821
this.patterns = patterns;
1922
}
2023

2124
@Override
2225
public boolean accept(File file) {
23-
return !GoLangFileMatch.match(patterns, file);
26+
String relativePath = file.getAbsolutePath().replaceFirst(base.getAbsolutePath() + File.separatorChar, "");
27+
28+
boolean match = GoLangFileMatch.match(patterns, relativePath);
29+
return !match;
2430
}
2531

2632

src/main/java/com/github/dockerjava/core/command/BuildImageCmdImpl.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
import java.net.URI;
77
import java.net.URISyntaxException;
88
import java.util.ArrayList;
9+
import java.util.Collection;
910
import java.util.HashMap;
1011
import java.util.List;
1112
import java.util.Map;
@@ -29,8 +30,6 @@
2930
*
3031
* Build an image from Dockerfile.
3132
*
32-
* TODO: http://docs.docker.com/reference/builder/#dockerignore
33-
*
3433
*/
3534
public class BuildImageCmdImpl extends AbstrDockerCmd<BuildImageCmd, InputStream> implements BuildImageCmd {
3635

@@ -243,8 +242,9 @@ protected InputStream buildDockerFolderTar(File dockerFolder) {
243242
"Source file %s doesn't exist", src));
244243
}
245244
if (src.isDirectory()) {
246-
filesToAdd.addAll(FileUtils.listFiles(src,
247-
new GoLangMatchFileFilter(ignores), TrueFileFilter.INSTANCE));
245+
Collection<File> files = FileUtils.listFiles(src,
246+
new GoLangMatchFileFilter(src, ignores), TrueFileFilter.INSTANCE);
247+
filesToAdd.addAll(files);
248248
} else if (!GoLangFileMatch.match(ignores, CompressArchiveUtil.relativize(dockerFolder, src))){
249249
filesToAdd.add(src);
250250
} else {
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
b
1+
b

0 commit comments

Comments
 (0)