Fix uniform init in out-of-class ctor-initer

Antti Tuppurainen · danmar · commit a75872a15e56 · 2015-07-14T18:09:07.000+02:00
diff --git a/lib/tokenize.cpp b/lib/tokenize.cpp
@@ -2931,15 +2931,15 @@ void Tokenizer::setVarId()
                     }
 
                     // constructor with initializer list
-                    if (Token::Match(tok2, ") : %name% (")) {
+                    if (Token::Match(tok2, ") : %name% (|{")) {
                         Token *tok3 = tok2;
                         do {
                             Token *vartok = tok3->tokAt(2);
                             if (varlist[classname].find(vartok->str()) != varlist[classname].end())
                                 vartok->varId(varlist[classname][vartok->str()]);
                             tok3 = tok3->linkAt(3);
-                        } while (Token::Match(tok3, ") [:,] %name% ("));
-                        if (Token::simpleMatch(tok3, ") {")) {
+                        } while (Token::Match(tok3, ")|} [:,] %name% (|{"));
+                        if (Token::Match(tok3, ")|} {")) {
                             setVarIdClassFunction(classname, tok2, tok3->next()->link(), varlist[classname], &structMembers, &_varId);
                         }
                     }
diff --git a/test/testclass.cpp b/test/testclass.cpp
@@ -6007,13 +6007,36 @@ class TestClass : public TestFixture {
                                 "};");
         ASSERT_EQUALS("[test.cpp:3]: (error) Member variable 's' is initialized by itself.\n", errout.str());
 
+        checkSelfInitialization("class Fred {\n"
+                                "    int x;\n"
+                                "    Fred(int x);\n"
+                                "};\n"
+                                "Fred::Fred(int x) : x(x) { }\n"
+								);
+        ASSERT_EQUALS("", errout.str());
+
+        checkSelfInitialization("class Fred {\n"
+                                "    int x;\n"
+                                "    Fred(int x);\n"
+                                "};\n"
+                                "Fred::Fred(int x) : x{x} { }\n"
+								);
+        ASSERT_EQUALS("", errout.str());
+
         checkSelfInitialization("class Fred {\n"
                                 "    std::string s;\n"
                                 "    Fred(const std::string& s) : s(s) {\n"
                                 "    }\n"
                                 "};");
         ASSERT_EQUALS("", errout.str());
 
+        checkSelfInitialization("class Fred {\n"
+                                "    std::string s;\n"
+                                "    Fred(const std::string& s) : s{s} {\n"
+                                "    }\n"
+                                "};");
+        ASSERT_EQUALS("", errout.str());
+
         checkSelfInitialization("struct Foo : Bar {\n"
                                 "    int i;\n"
                                 "    Foo(int i)\n"
diff --git a/test/testvarid.cpp b/test/testvarid.cpp
@@ -156,6 +156,7 @@ class TestVarID : public TestFixture {
         TEST_CASE(varidclass15);  // initializer list
         TEST_CASE(varidclass16);  // #4577
         TEST_CASE(varidclass17);  // #6073
+        TEST_CASE(varidclass18);
         TEST_CASE(varid_classnameshaddowsvariablename); // #3990
 
         TEST_CASE(varidnamespace1);
@@ -2541,6 +2542,23 @@ class TestVarID : public TestFixture {
         ASSERT_EQUALS(expected, tokenize(code));
     }
 
+    void varidclass18() {
+        const char code[] = "class A {\n"
+                            "    int a;\n"
+                            "    int b;\n"
+                            "    A();\n"
+                            "};\n"
+                            "A::A() : a{0} { b = 1; }";
+        const char expected[] = "\n\n##file 0\n"
+                                "1: class A {\n"
+                                "2: int a@1 ;\n"
+                                "3: int b@2 ;\n"
+                                "4: A ( ) ;\n"
+                                "5: } ;\n"
+                                "6: A :: A ( ) : a@1 { 0 } { b@2 = 1 ; }\n";
+        ASSERT_EQUALS(expected, tokenize(code));
+    }
+
     void varid_classnameshaddowsvariablename() {
         const char code[] = "class Data;\n"
                             "void strange_declarated(const Data& Data);\n"

Original file line number	Diff line number	Diff line change
`@@ -2931,15 +2931,15 @@ void Tokenizer::setVarId()`
`2931`	`2931`	`}`
`2932`	`2932`
`2933`	`2933`	`// constructor with initializer list`
`2934`		`- if (Token::Match(tok2, ") : %name% (")) {`
	`2934`	`+ if (Token::Match(tok2, ") : %name% (\|{")) {`
`2935`	`2935`	`Token *tok3 = tok2;`
`2936`	`2936`	`do {`
`2937`	`2937`	`Token *vartok = tok3->tokAt(2);`
`2938`	`2938`	`if (varlist[classname].find(vartok->str()) != varlist[classname].end())`
`2939`	`2939`	`vartok->varId(varlist[classname][vartok->str()]);`
`2940`	`2940`	`tok3 = tok3->linkAt(3);`
`2941`		`- } while (Token::Match(tok3, ") [:,] %name% ("));`
`2942`		`- if (Token::simpleMatch(tok3, ") {")) {`
	`2941`	`+ } while (Token::Match(tok3, ")\|} [:,] %name% (\|{"));`
	`2942`	`+ if (Token::Match(tok3, ")\|} {")) {`
`2943`	`2943`	`setVarIdClassFunction(classname, tok2, tok3->next()->link(), varlist[classname], &structMembers, &_varId);`
`2944`	`2944`	`}`
`2945`	`2945`	`}`