Fixed cppcheck-opensource#4642 (False positive: Returning an address value in a function with integer return type is not portable. (not returning address))

amai2012 · danmar · commit 9d88cc63e86b · 2013-03-12T06:49:13.000+01:00
diff --git a/lib/check64bit.cpp b/lib/check64bit.cpp
@@ -77,7 +77,9 @@ void Check64BitPortability::pointerassignment()
                     else if (Token::Match(tok2, "%type% (")) {
                         type = NO;
                         break;
-                    } else if (tok2->str() == ";")
+                    } else if (type == PTR && Token::simpleMatch(tok2, "."))
+                        type = NO; // Reset after pointer reference, see #4642
+                    else if (tok2->str() == ";")
                         break;
                 }
 
diff --git a/test/test64bit.cpp b/test/test64bit.cpp
@@ -180,6 +180,14 @@ class Test64BitPortability : public TestFixture {
               "    return a + 1 - b;\n"
               "}");
         ASSERT_EQUALS("", errout.str());
+
+        check("struct s {\n" // 4642
+              "   int i;\n"
+              "};\n"
+              "int func(struct s *p) {\n"
+              " return 1 + p->i;\n"
+              "}");
+        ASSERT_EQUALS("", errout.str());
     }
 };
 
