CheckCondition::alwaysTrueFalseError: put condition in single quotes.

matthiaskrgr · matthiaskrgr · commit 21ed807f8dd5 · 2015-07-31T15:28:37.000+02:00
diff --git a/lib/checkcondition.cpp b/lib/checkcondition.cpp
@@ -1012,5 +1012,5 @@ void CheckCondition::alwaysTrueFalseError(const Token *tok, bool knownResult)
     reportError(tok,
                 Severity::style,
                 "knownConditionTrueFalse",
-                "Condition " + expr + " is always " + (knownResult ? "true" : "false"));
+                "Condition '" + expr + "' is always " + (knownResult ? "true" : "false"));
 }
diff --git a/test/testcondition.cpp b/test/testcondition.cpp
@@ -1519,7 +1519,7 @@ class TestCondition : public TestFixture {
               "  if (a) { return; }\n" // <- this is just here to fool simplifyKnownVariabels
               "  if (!x) {}\n"
               "}");
-        ASSERT_EQUALS("[test.cpp:4]: (style) Condition !x is always true\n", errout.str());
+        ASSERT_EQUALS("[test.cpp:4]: (style) Condition '!x' is always true\n", errout.str());
 
         check("void f() {\n" // #6898 (Token::expressionString)
               "  int x = 0;\n"

Original file line number	Diff line number	Diff line change
`@@ -1012,5 +1012,5 @@ void CheckCondition::alwaysTrueFalseError(const Token *tok, bool knownResult)`
`1012`	`1012`	`reportError(tok,`
`1013`	`1013`	`Severity::style,`
`1014`	`1014`	`"knownConditionTrueFalse",`
`1015`		`- "Condition " + expr + " is always " + (knownResult ? "true" : "false"));`
	`1015`	`+ "Condition '" + expr + "' is always " + (knownResult ? "true" : "false"));`
`1016`	`1016`	`}`