Skip to content

Commit 66c640b

Browse files
Upgrade rimraf: 3.0.2 → 4.1.2 (major) (tailwindlabs#10596)
* Update rimraf to version 4.1.2 * use rimraf sync API Our `oxide` engine uses rimraf v4, our `stable` engine uses rimraf v3 and the API is different in both. However the tests are currently shared for both engines so we have to use the correct API for the correct version. However, we can also just use the `sync` API. More info: https://github.com/isaacs/rimraf#major-changes-from-v3-to-v4 --------- Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
1 parent e3f9ea4 commit 66c640b

3 files changed

Lines changed: 70 additions & 27 deletions

File tree

jest/runInTempDirectory.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,9 @@ export default function (callback) {
1717

1818
callback().then(() => {
1919
process.chdir(currentPath)
20-
rimraf(tmpPath, resolve)
20+
21+
rimraf.sync(tmpPath)
22+
resolve()
2123
})
2224
})
2325
}

package-lock.json

Lines changed: 66 additions & 25 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@
6262
"jest": "^29.4.1",
6363
"jest-diff": "^29.4.1",
6464
"prettier": "^2.8.4",
65-
"rimraf": "^3.0.0",
65+
"rimraf": "^4.1.2",
6666
"source-map-js": "^1.0.2",
6767
"turbo": "^1.7.4"
6868
},

0 commit comments

Comments
 (0)