Enhanced: given_when_then pattern naming and formatting problems are resolved

mnafshin · mnafshin · commit 78cb7a3a3fe5 · 2019-10-07T11:52:22.000+02:00
diff --git a/core-java-modules/core-java/src/test/java/com/baeldung/encoding/CharacterEncodingExamplesUnitTest.java b/core-java-modules/core-java/src/test/java/com/baeldung/encoding/CharacterEncodingExamplesUnitTest.java
@@ -74,29 +74,28 @@ public void givenCharacterCh_whenConvertedtoBinaryWithEncodingUTF32_thenProduceR
     }
 
     @Test
-    public void givenUTF8String_decodeByUS_ASCII_ReplaceMalformedInputSequence() throws IOException {
-        String input = "The fa&ccedil;ade pattern is a software design pattern.";
-        Assertions.assertEquals("The fa&#65533;&#65533;ade pattern is a software design pattern.",
-          CharacterEncodingExamples.decodeText(input, StandardCharsets.US_ASCII, CodingErrorAction.REPLACE));
+    public void givenUTF8String_whenDecodeByUS_ASCII_thenIgnoreMalformedInputSequence() throws IOException {
+        Assertions.assertEquals("The faade pattern is a software design pattern.",
+            CharacterEncodingExamples.decodeText(
+                "The fa&ccedil;ade pattern is a software design pattern.", StandardCharsets.US_ASCII, CodingErrorAction.IGNORE));
     }
 
     @Test
-    public void givenUTF8String_decodeByUS_ASCII_IgnoreMalformedInputSequence() throws IOException {
-        String input = "The fa&ccedil;ade pattern is a software design pattern.";
-        Assertions.assertEquals(
-          "The faade pattern is a software design pattern.",
-          CharacterEncodingExamples.decodeText(input, StandardCharsets.US_ASCII, CodingErrorAction.IGNORE));
+    public void givenUTF8String_whenDecodeByUS_ASCII_thenReplaceMalformedInputSequence() throws IOException {
+        Assertions.assertEquals("The fa&#65533;&#65533;ade pattern is a software design pattern.",
+          CharacterEncodingExamples.decodeText(
+              "The fa&ccedil;ade pattern is a software design pattern.", StandardCharsets.US_ASCII, CodingErrorAction.REPLACE));
     }
 
     @Test
-    public void givenUTF8String_decodeByUS_ASCII_ReportMalformedInputSequence() {
-        String input = "The fa&ccedil;ade pattern is a software design pattern.";
+    public void givenUTF8String_whenDecodeByUS_ASCII_thenReportMalformedInputSequence() {
         Assertions.assertThrows(MalformedInputException.class,
-          () -> CharacterEncodingExamples.decodeText(input, StandardCharsets.US_ASCII, CodingErrorAction.REPORT));
+          () -> CharacterEncodingExamples.decodeText(
+              "The fa&ccedil;ade pattern is a software design pattern.", StandardCharsets.US_ASCII, CodingErrorAction.REPORT));
     }
 
     @Test
-    public void givenTextFile_FindSuitableCandidateEncodings() {
+    public void givenTextFile_whenFindSuitableCandidateEncodings_thenProduceSuitableCandidateEncodings() {
         Path path = Paths.get("src/test/resources/encoding.txt");
         List<Charset> allCandidateCharSets = Arrays.asList(
           StandardCharsets.US_ASCII, StandardCharsets.UTF_8, StandardCharsets.ISO_8859_1);
@@ -113,6 +112,7 @@ public void givenTextFile_FindSuitableCandidateEncodings() {
                 ex.printStackTrace();
             }
         });
+
         Assertions.assertEquals(suitableCharsets, Arrays.asList(StandardCharsets.UTF_8, StandardCharsets.ISO_8859_1));
     }
 
