Skip to content

Simplify Expected<V, E> IPC encoder#61325

Open
cdumez wants to merge 1 commit intoWebKit:mainfrom
cdumez:310708_Expected_encoder
Open

Simplify Expected<V, E> IPC encoder#61325
cdumez wants to merge 1 commit intoWebKit:mainfrom
cdumez:310708_Expected_encoder

Conversation

@cdumez
Copy link
Contributor

@cdumez cdumez commented Mar 25, 2026 •
edited by webkit-early-warning-system
Loading

e54223c

Simplify Expected<V, E> IPC encoder
https://bugs.webkit.org/show_bug.cgi?id=310708

Reviewed by NOBODY (OOPS!).

Simplify Expected<V, E> IPC encoder, by replacing the two separate
encode overloads (const lvalue ref + rvalue ref) with a single
forwarding-reference overload, matching the pattern used by
std::optional, std::pair, std::tuple, and others in the same file.

* Source/WebKit/Platform/IPC/ArgumentCoders.h:

e54223c

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win ⏳ 🛠 ios-apple
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests ⏳ 🛠 mac-apple
✅ 🧪 webkitperl loading 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe ⏳ 🛠 vision-apple
loading 🧪 ios-wk2-wpt ⏳ 🧪 api-mac-debug ✅ 🛠 gtk3-libwebrtc
⏳ 🧪 api-ios ✅ 🛠 gtk
✅ 🛠 ios-safer-cpp ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🛠 playstation
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@cdumez
Simplify Expected<V, E> IPC encoder
e54223c 
https://bugs.webkit.org/show_bug.cgi?id=310708

Reviewed by NOBODY (OOPS!).

Simplify Expected<V, E> IPC encoder, by replacing the two separate
encode overloads (const lvalue ref + rvalue ref) with a single
forwarding-reference overload, matching the pattern used by
std::optional, std::pair, std::tuple, and others in the same file.

* Source/WebKit/Platform/IPC/ArgumentCoders.h:
@cdumez cdumez self-assigned this Mar 25, 2026
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Mar 25, 2026 •
edited
Loading

EWS run on current version of this PR (hash e54223c)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win ⏳ 🛠 ios-apple
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests ⏳ 🛠 mac-apple
✅ 🧪 webkitperl loading 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe ⏳ 🛠 vision-apple
loading 🧪 ios-wk2-wpt ⏳ 🧪 api-mac-debug ✅ 🛠 gtk3-libwebrtc
⏳ 🧪 api-ios ✅ 🛠 gtk
✅ 🛠 ios-safer-cpp ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🛠 playstation
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@cdumez cdumez added the WebKit2 Bugs relating to the WebKit2 API layer label Mar 25, 2026
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Mar 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@cdumez cdumez

Labels

merging-blocked Applied to prevent a change from being merged WebKit2 Bugs relating to the WebKit2 API layer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cdumez @webkit-early-warning-system @webkit-ews-buildbot