[IndexedDB API] Support IDBGetAllOptions in IDBIndex::getAllKeys()#61317
Draft
RupinMittal wants to merge 1 commit intoWebKit:mainfrom
Draft
[IndexedDB API] Support IDBGetAllOptions in IDBIndex::getAllKeys()#61317RupinMittal wants to merge 1 commit intoWebKit:mainfrom
RupinMittal wants to merge 1 commit intoWebKit:mainfrom
Conversation
Collaborator
|
EWS run on previous version of this PR (hash 4f8bde4) Details
|
https://bugs.webkit.org/show_bug.cgi?id=310700 rdar://173311682 Reviewed by NOBODY (OOPS!). This is just a draft I've uploaded so I can see what EWS thinks of it. * LayoutTests/imported/w3c/web-platform-tests/IndexedDB/idbindex_getAllKeys-options.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/IndexedDB/idbindex_getAllKeys-options.any.serviceworker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/IndexedDB/idbindex_getAllKeys-options.any.sharedworker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/IndexedDB/idbindex_getAllKeys-options.any.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/IndexedDB/key-conversion-exceptions.any-expected.txt: * Source/WebCore/Modules/indexeddb/IDBIndex.cpp: (WebCore::IDBIndex::doGetAll): (WebCore::IDBIndex::doGetAllKeys): (WebCore::IDBIndex::getAllKeys): * Source/WebCore/Modules/indexeddb/IDBIndex.h: * Source/WebCore/Modules/indexeddb/IDBIndex.idl: * Source/WebCore/Modules/indexeddb/IDBTransaction.cpp: (WebCore::IDBTransaction::requestGetAllObjectStoreRecords): (WebCore::IDBTransaction::requestGetAllIndexRecords): * Source/WebCore/Modules/indexeddb/IDBTransaction.h: * Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp: (WebCore::IDBServer::SQLiteIDBBackingStore::getAllIndexRecords): * Source/WebCore/Modules/indexeddb/server/SQLiteIDBCursor.cpp: (WebCore::IDBServer::SQLiteIDBCursor::maybeCreateBackingStoreCursor): (WebCore::IDBServer::SQLiteIDBCursor::SQLiteIDBCursor): * Source/WebCore/Modules/indexeddb/server/SQLiteIDBCursor.h: * Source/WebCore/Modules/indexeddb/server/SQLiteIDBTransaction.cpp: (WebCore::IDBServer::SQLiteIDBTransaction::maybeOpenBackingStoreCursor): * Source/WebCore/Modules/indexeddb/server/SQLiteIDBTransaction.h: * Source/WebCore/Modules/indexeddb/shared/IDBGetAllRecordsData.cpp: (WebCore::IDBGetAllRecordsData::isolatedCopy const): (WebCore::IDBGetAllRecordsData::loggingString const): * Source/WebCore/Modules/indexeddb/shared/IDBGetAllRecordsData.h: * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:
4f8bde4 to
d0cd40a
Compare
Collaborator
|
EWS run on current version of this PR (hash d0cd40a) Details
|
Collaborator
macOS Safer C++ Build #88607 (d0cd40a)❌ Found 1 failing file with 3 issues. Please address these issues before landing. See WebKit Guidelines for Safer C++ Programming. |
Collaborator
iOS Safer C++ Build #6479 (d0cd40a)❌ Found 1 failing file with 3 issues. Please address these issues before landing. See WebKit Guidelines for Safer C++ Programming. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧪 win-tests
d0cd40a
d0cd40a