Move optional metadata field so its not last#2909
Merged
Conversation
To avoid the conditional trailing comma.
Member
Author
|
As alternative to #2908.. is it better? I'm not sure. |
dschuff
approved these changes
Jun 11, 2020
Member
dschuff
left a comment
dschuff
left a comment
There was a problem hiding this comment.
This is fine too if you prefer it.
Member
|
I guess we risk running into the problem again in the future if we add another optional at the end, but 🤷 . |
Member
Author
|
I guess that idea is that we just need to make sure that optional fields are not last.. Not sure its worth a comment but perhaps worth adding to the tests to ensure the output is valid json? Given that this was not caught before emscripten integration. |
Member
Author
|
Added json parsing to tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To avoid the conditional trailing comma.