ci: fix BitNet FetchContent checkout failure#4640
ci: fix BitNet FetchContent checkout failure#4640vishal2005025 wants to merge 1 commit intoWasmEdge:masterfrom
Conversation
Signed-off-by: vishal2005025 <[email protected]>
|
Have you verified that the build is working after bumping the version? |
hydai
left a comment
There was a problem hiding this comment.
Bumping version without enough verification.
|
@hydai I verified this locally by deleting the build directory, reconfiguring, and rebuilding, and the build completes successfully with the updated BitNet commit. |
Hi, CI checks are still failing on ubuntu https://github.com/vishal2005025/WasmEdge/actions/runs/21863594641/job/63099345148?pr=3 |
|
@Divyansh200102 The original CI failure was caused by BitNet failing to fetch due to an invalid pinned commit. With this change, BitNet is fetched successfully and CI progresses further. |
I know but currently the bitnet workflow seems to be working fine after disabling the shadow clone so bumping the version for this specific problem doesn't make sense to me and it isn't solving the issue.
also you said here that this commit doesn't exist but I do see it in the upstream microsoft/BitNet@404980e . So this was likely a shadow clone problem and not something that needs a version bump.
|
|
@Divyansh200102 Thanks, I just checked and it looks like the BitNet workflow is now working after disabling the shallow clone and allowing a full history fetch. |

Fixes: #4635
Summary
This PR Fixes CI failure in the WASI-NN BitNet backend by updating the pinned BitNet.cpp commit. The previously used commit (
404980e) no longer exists upstream, causing FetchContent checkout to fail. This change updates theGIT_TAGto a valid commit from the BitNetmainbranch, unblocking CI.Changes
GIT_TAGincmake/WASINNDeps.cmaketo a valid upstream commitReference: https://github.com/microsoft/BitNet/commits/main/