-
Notifications
You must be signed in to change notification settings - Fork 553
Open
Description
The application starts tor / tor.exe at the application startup. Tor is not, by default, stopped when the application stops. Now the issue is that when one rebuilds the .NET solution and the tor.exe is running, then tor.exe is locked and the source tor.exe file is not copied from its source folder to the target folder as expected. See source code.
This leads to a few unexpected outcomes:
- When switching between git branches, I think that an unexpected version of Tor binary can still run. In general, it's not a big issue but it's not correct.
- Avalonia's icon is not copied to the output folder and it is missing if tor.exe is locked. This is, I believe, because the icon is deleted while rebuilding the .NET solution but the tor being locked leads to not copying of
WasabiLogo.icofile (files are copied by msbuild in batches, not one by one, something like this). This is not a big bug but it's not great either because it's not clear what else might be missing.
It's surprisingly hard to fail the build if tor.exe is locked. So far I have not found any way to fix this.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels