Skip to content

Commit 5568356

Browse files
author
Oskari Leppäaho
committed
Fix password not getting hidden
EditText.setSingleLine() was resetting the EditText settings. We'll have to call that before setting the InputType. Also the InputType.TYPE_CLASS_TEXT flag has to be set for the password character hiding to work.
1 parent d558f03 commit 5568356

1 file changed

Lines changed: 5 additions & 4 deletions

File tree

  • src/androidProj/nativeeditplugin/src/main/java/com/bkmin/android

src/androidProj/nativeeditplugin/src/main/java/com/bkmin/android/EditBox.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -224,16 +224,18 @@ public void Create(int _tag, JSONObject jsonObj)
224224
edit.setLayoutParams(lp);
225225
edit.setPadding(0, 0, 0, 0);
226226

227-
int editInputType = edit.getInputType();
227+
edit.setSingleLine(!multiline);
228+
229+
int editInputType = 0;
228230
switch (contentType) {
229231
case "Standard" : editInputType |= InputType.TYPE_CLASS_TEXT | InputType.TYPE_TEXT_FLAG_CAP_SENTENCES | InputType.TYPE_TEXT_VARIATION_NORMAL; break; // This is default behaviour
230232
case "Autocorrected" : editInputType |= InputType.TYPE_CLASS_TEXT | InputType.TYPE_TEXT_FLAG_CAP_SENTENCES | InputType.TYPE_TEXT_FLAG_AUTO_CORRECT; break;
231233
case "IntegerNumber" : editInputType |= InputType.TYPE_CLASS_NUMBER | InputType.TYPE_NUMBER_VARIATION_NORMAL; break;
232234
case "DecimalNumber" : editInputType |= InputType.TYPE_CLASS_NUMBER | InputType.TYPE_NUMBER_FLAG_DECIMAL; break;
233235
case "Alphanumeric" : editInputType |= InputType.TYPE_CLASS_TEXT | InputType.TYPE_TEXT_FLAG_CAP_SENTENCES | InputType.TYPE_TEXT_VARIATION_NORMAL; break; // This is default behaviour
234236
case "Name" : editInputType |= InputType.TYPE_TEXT_VARIATION_PERSON_NAME; break;
235-
case "EmailAddress" : editInputType |= InputType.TYPE_TEXT_VARIATION_EMAIL_ADDRESS; break;
236-
case "Password" : editInputType |= InputType.TYPE_TEXT_VARIATION_PASSWORD; break;
237+
case "EmailAddress" : editInputType |= InputType.TYPE_CLASS_TEXT | InputType.TYPE_TEXT_VARIATION_EMAIL_ADDRESS; break;
238+
case "Password" : editInputType |= InputType.TYPE_CLASS_TEXT | InputType.TYPE_TEXT_VARIATION_PASSWORD; break;
237239
case "Pin" : editInputType |= InputType.TYPE_TEXT_VARIATION_PHONETIC; break;
238240

239241
case "Custom" : // We need more details
@@ -318,7 +320,6 @@ else if (returnKeyType.equals("Done")) {
318320

319321
Typeface tf = Typeface.create(font, Typeface.NORMAL);
320322
edit.setTypeface(tf);
321-
edit.setSingleLine(!multiline);
322323

323324
final EditBox eb = this;
324325

0 commit comments

Comments
 (0)