Skip to content

Commit 9297923

Browse files
committed
Remove redundant setStartAtZero method from YAxis.
2 parents b47dd65 + 4f5a32d commit 9297923

33 files changed

Lines changed: 48 additions & 248 deletions

MPChartExample/res/menu/bar.xml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,6 @@
2525
android:id="@+id/animateXY"
2626
android:title="Animate XY">
2727
</item>
28-
<item
29-
android:id="@+id/actionToggleStartzero"
30-
android:title="Toggle StartZero">
31-
</item>
3228
<item
3329
android:id="@+id/actionToggleAdjustXLegend"
3430
android:title="Toggle AdjustXLegend">

MPChartExample/res/menu/bubble.xml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,6 @@
99
android:id="@+id/actionToggleHighlight"
1010
android:title="Toggle Highlight">
1111
</item>
12-
<item
13-
android:id="@+id/actionToggleStartzero"
14-
android:title="Toggle StartZero">
15-
</item>
1612
<item
1713
android:id="@+id/actionToggleAdjustXLegend"
1814
android:title="Toggle AdjustXLegend">

MPChartExample/res/menu/candle.xml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,6 @@
55
android:id="@+id/actionToggleHighlight"
66
android:title="Toggle Highlight">
77
</item>
8-
<item
9-
android:id="@+id/actionToggleStartzero"
10-
android:title="Toggle StartZero">
11-
</item>
128
<item
139
android:id="@+id/animateX"
1410
android:title="Animate X">

MPChartExample/res/menu/draw.xml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,6 @@
1717
android:id="@+id/actionToggleHighlight"
1818
android:title="Toggle Highlight">
1919
</item>
20-
<item
21-
android:id="@+id/actionToggleStartzero"
22-
android:title="Toggle StartZero">
23-
</item>
2420
<item
2521
android:id="@+id/actionToggleAdjustXLegend"
2622
android:title="Toggle AdjustXLegend">

MPChartExample/res/menu/line.xml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,6 @@
2121
android:id="@+id/actionToggleHighlight"
2222
android:title="Toggle Highlight">
2323
</item>
24-
<item
25-
android:id="@+id/actionToggleStartzero"
26-
android:title="Toggle StartZero">
27-
</item>
2824
<item
2925
android:id="@+id/animateX"
3026
android:title="Animate X">

MPChartExample/res/menu/scatter.xml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,6 @@
99
android:id="@+id/actionToggleHighlight"
1010
android:title="Toggle Highlight">
1111
</item>
12-
<item
13-
android:id="@+id/actionToggleStartzero"
14-
android:title="Toggle StartZero">
15-
</item>
1612
<item
1713
android:id="@+id/actionToggleAdjustXLegend"
1814
android:title="Toggle AdjustXLegend">

MPChartExample/src/com/xxmassdeveloper/mpchartexample/AnotherBarActivity.java

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -134,13 +134,6 @@ public boolean onOptionsItemSelected(MenuItem item) {
134134
mChart.invalidate();
135135
break;
136136
}
137-
case R.id.actionToggleStartzero: {
138-
139-
mChart.getAxisLeft().setStartAtZero(!mChart.getAxisLeft().isStartAtZeroEnabled());
140-
mChart.getAxisRight().setStartAtZero(!mChart.getAxisRight().isStartAtZeroEnabled());
141-
mChart.invalidate();
142-
break;
143-
}
144137
case R.id.animateX: {
145138
mChart.animateX(3000);
146139
break;

MPChartExample/src/com/xxmassdeveloper/mpchartexample/BarChartActivity.java

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -173,13 +173,6 @@ public boolean onOptionsItemSelected(MenuItem item) {
173173
mChart.invalidate();
174174
break;
175175
}
176-
case R.id.actionToggleStartzero: {
177-
mChart.getAxisLeft().setStartAtZero(!mChart.getAxisLeft().isStartAtZeroEnabled());
178-
mChart.getAxisRight().setStartAtZero(!mChart.getAxisRight().isStartAtZeroEnabled());
179-
mChart.notifyDataSetChanged();
180-
mChart.invalidate();
181-
break;
182-
}
183176
case R.id.animateX: {
184177
mChart.animateX(3000);
185178
break;
@@ -251,7 +244,7 @@ private void setData(int count, float range) {
251244

252245
for (int i = 0; i < count; i++) {
253246
float mult = (range + 1);
254-
float val = (float) (Math.random() * mult);
247+
float val = -10; //(float) (Math.random() * mult);
255248
yVals1.add(new BarEntry(val, i));
256249
}
257250

MPChartExample/src/com/xxmassdeveloper/mpchartexample/BarChartActivityMultiDataset.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -149,12 +149,6 @@ public boolean onOptionsItemSelected(MenuItem item) {
149149
mChart.invalidate();
150150
break;
151151
}
152-
case R.id.actionToggleStartzero: {
153-
mChart.getAxisLeft().setStartAtZero(!mChart.getAxisLeft().isStartAtZeroEnabled());
154-
mChart.getAxisRight().setStartAtZero(!mChart.getAxisRight().isStartAtZeroEnabled());
155-
mChart.invalidate();
156-
break;
157-
}
158152
case R.id.actionSave: {
159153
// mChart.saveToGallery("title"+System.currentTimeMillis());
160154
mChart.saveToPath("title" + System.currentTimeMillis(), "");

MPChartExample/src/com/xxmassdeveloper/mpchartexample/BarChartActivitySinus.java

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -87,15 +87,13 @@ protected void onCreate(Bundle savedInstanceState) {
8787
YAxis leftAxis = mChart.getAxisLeft();
8888
leftAxis.setTypeface(mTf);
8989
leftAxis.setLabelCount(6, false);
90-
leftAxis.setStartAtZero(false);
9190
leftAxis.setAxisMinValue(-2.5f);
9291
leftAxis.setAxisMaxValue(2.5f);
9392

9493
YAxis rightAxis = mChart.getAxisRight();
9594
rightAxis.setDrawGridLines(false);
9695
rightAxis.setTypeface(mTf);
9796
rightAxis.setLabelCount(6, false);
98-
rightAxis.setStartAtZero(false);
9997
rightAxis.setAxisMinValue(-2.5f);
10098
rightAxis.setAxisMaxValue(2.5f);
10199

@@ -158,13 +156,6 @@ public boolean onOptionsItemSelected(MenuItem item) {
158156
mChart.invalidate();
159157
break;
160158
}
161-
case R.id.actionToggleStartzero: {
162-
mChart.getAxisLeft().setStartAtZero(!mChart.getAxisLeft().isStartAtZeroEnabled());
163-
mChart.getAxisRight().setStartAtZero(!mChart.getAxisRight().isStartAtZeroEnabled());
164-
mChart.notifyDataSetChanged();
165-
mChart.invalidate();
166-
break;
167-
}
168159
case R.id.animateX: {
169160
mChart.animateX(1500);
170161
break;

0 commit comments

Comments
 (0)